Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 1.24.1 #422

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Bump version to 1.24.1 #422

merged 1 commit into from
Jun 21, 2022

Conversation

nckturner
Copy link
Contributor

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind cleanup

What this PR does / why we need it:

  • Bump version to 1.24.1
  • Test automatic tagging

Does this PR introduce a user-facing change?:

NONE

@nckturner
Bump version to 1.24.1
8b00144 
Test automatic tagging
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2022
@nckturner
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 21, 2022
@wongma7
Copy link
Contributor

wongma7 commented Jun 21, 2022

shouldn't the tagging be on release branch? not sure if you mean git or image tag?

@wongma7
Copy link
Contributor

wongma7 commented Jun 21, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit b9c8d82 into kubernetes:master Jun 21, 2022
@nckturner
Copy link
Contributor Author

nckturner commented Jun 22, 2022 •
edited
Loading

@wongma7 To answer your question its git tag that is created automatically. And yes, in the future we can/should create the newest release branch as soon as we have create the first patch release to ensure we can be selective about what commits get into that versions releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes Awaiting requested review from jaypipes

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nckturner @wongma7 @k8s-ci-robot