Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message in readonly approver #376

Merged
merged 1 commit into from Oct 17, 2022
Merged

Fix error message in readonly approver #376

merged 1 commit into from Oct 17, 2022

Conversation

blackzlq
Copy link
Contributor

Fix response err miss response

Tested:

Unit test
local test

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @blackzlq. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2022
@blackzlq
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@blackzlq: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vinayakankugoyal
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2022
hoskeri
hoskeri reviewed Oct 12, 2022
View reviewed changes
Copy link
Contributor

@hoskeri hoskeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is not clear.
Suggest:

Fix validator error message in readonly approver.

validation error is in response.err, not in err.

Tested...

cmd/gcp-controller-manager/kubelet_readonly_csr_approver.go Outdated Show resolved Hide resolved
@blackzlq blackzlq changed the title Fix a mistake missing response Fix error message in readonly approver Oct 12, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2022
vinayakankugoyal
vinayakankugoyal reviewed Oct 14, 2022
View reviewed changes
cmd/gcp-controller-manager/kubelet_readonly_csr_approver_test.go Outdated Show resolved Hide resolved
cmd/gcp-controller-manager/kubelet_readonly_csr_approver_test.go Outdated Show resolved Hide resolved
cmd/gcp-controller-manager/kubelet_readonly_csr_approver_test.go Outdated Show resolved Hide resolved
cmd/gcp-controller-manager/kubelet_readonly_csr_approver_test.go Outdated Show resolved Hide resolved
cmd/gcp-controller-manager/kubelet_readonly_csr_approver_test.go Outdated Show resolved Hide resolved
cmd/gcp-controller-manager/kubelet_readonly_csr_approver_test.go Outdated Show resolved Hide resolved
cmd/gcp-controller-manager/kubelet_readonly_csr_approver_test.go Outdated Show resolved Hide resolved
cmd/gcp-controller-manager/kubelet_readonly_csr_approver_test.go Outdated Show resolved Hide resolved
cmd/gcp-controller-manager/kubelet_readonly_csr_approver_test.go Outdated Show resolved Hide resolved
cmd/gcp-controller-manager/kubelet_readonly_csr_approver_test.go Outdated Show resolved Hide resolved
@vinayakankugoyal
Copy link
Contributor

/lgtm

@blackzlq - can you please squash all the commits together.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2022
@blackzlq
Fix error message and format
a97cf60 
1. fix incorrect case
2. move got before expect
3. removed unnecessary bool
4. removed unnecessary break
5. Update the if/else block to be switch
6. modify the message in error
7. Fix validator error message in readonly approver.
8. validation error is in response.err, not in err.

Tested:

Unit test
local test
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2022
@blackzlq
Copy link
Contributor Author

/assign @vinayakankugoyal

@blackzlq
Copy link
Contributor Author

squashed the commits

@vinayakankugoyal
Copy link
Contributor

/lgtm

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2022
@vinayakankugoyal
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blackzlq, vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blackzlq, vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 064029e into kubernetes:master Oct 17, 2022
@blackzlq blackzlq deleted the myfeature branch October 17, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoskeri hoskeri hoskeri left review comments

@vinayakankugoyal vinayakankugoyal vinayakankugoyal left review comments

@sambdavidson sambdavidson Awaiting requested review from sambdavidson

Assignees

@vinayakankugoyal vinayakankugoyal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blackzlq @k8s-ci-robot @vinayakankugoyal @hoskeri