Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message in readonly approver #376

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Fix error message in readonly approver #376

merged 1 commit into from
Oct 17, 2022

Commits on Oct 17, 2022

  1. Fix error message and format 

    1. fix incorrect case
2. move got before expect
3. removed unnecessary bool
4. removed unnecessary break
5. Update the if/else block to be switch
6. modify the message in error
7. Fix validator error message in readonly approver.
8. validation error is in response.err, not in err.

Tested:

Unit test
local test
    @blackzlq
    blackzlq committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    a97cf60 View commit details
    Browse the repository at this point in the history