Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cinder-csi-plugin] Add volume condition for controller and node plugin #1585

Closed
wants to merge 1 commit into from
Closed

[cinder-csi-plugin] Add volume condition for controller and node plugin #1585

wants to merge 1 commit into from

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Jul 6, 2021 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #1584

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 6, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 6, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 6, 2021

Build succeeded.

@jichenjc jichenjc force-pushed the add_controller_volume_condition branch from 6ee8f63 to bc1e1de Compare July 6, 2021 08:53
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2021
@jichenjc jichenjc changed the title WIP[cinder-csi-plugin] :Add volume condition for controller [cinder-csi-plugin]Add volume condition for controller Jul 6, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 6, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

jichenjc commented Jul 6, 2021

/test cloud-provider-openstack-e2e-test-csi-cinder

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-e2e-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 6, 2021

Build succeeded.

@jichenjc jichenjc force-pushed the add_controller_volume_condition branch from bc1e1de to 0188eb0 Compare July 7, 2021 07:28
@jichenjc jichenjc changed the title [cinder-csi-plugin]Add volume condition for controller [cinder-csi-plugin]Add volume condition for controller and node plugin Jul 7, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 7, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 7, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 7, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 7, 2021

Build succeeded.

@lingxiankong
Copy link
Contributor

/override openlab/cloud-provider-openstack-multinode-csi-migration-test
/override openstack-cloud-keystone-authentication-authorization-test

@jichenjc May I know what is the current status of the job openstack-cloud-keystone-authentication-authorization-test? It's here but I see it's never passed.

@k8s-ci-robot
Copy link
Contributor

@lingxiankong: Overrode contexts on behalf of lingxiankong: openlab/cloud-provider-openstack-multinode-csi-migration-test, openstack-cloud-keystone-authentication-authorization-test

In response to this:

/override openlab/cloud-provider-openstack-multinode-csi-migration-test
/override openstack-cloud-keystone-authentication-authorization-test

@jichenjc May I know what is the current status of the job openstack-cloud-keystone-authentication-authorization-test? It's here but I see it's never passed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lingxiankong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2021
@ramineni
Copy link
Contributor

@jichenjc Thanks for the PR. Trying to understand better, is this volume conditions are used only if external health monitor is enabled is supported/enabled? not used otherwise? because, I see that external health monitor is a separate sidecar and alpha feature only, so if we dont have plans to add support now , I dont think we should add this

@jichenjc
Copy link
Contributor Author

@ramineni I thought we should catch up with CSI spec and adopt new features time to time?
or if it's alpha, maybe we can put it as optional feature of CPO? let me know your thoughts :)

@ramineni
Copy link
Contributor

@ramineni I thought we should catch up with CSI spec and adopt new features time to time?

@jichenjc +1 , yes I agree.

or if it's alpha, maybe we can put it as optional feature of CPO? let me know your thoughts :)

Actually 3 things crossed my mind -

  1. I see external health monitor is a big feature and needs proper testing /configuration before adding it here.
  2. As VOLUME_CONDITION is only part of the feature, may be its better to add it as a whole feature with tests enabled.
  3. And as its only alpha , Im wondering is it worth the effort , may be we should wait until beta .

wdyt?

@jichenjc
Copy link
Contributor Author

And as its only alpha , Im wondering is it worth the effort , may be we should wait until beta .

ok, seems we can create some kind of criteria, another thought
makes me think it might be safer for us ..so I agree with you on this

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2022
@jichenjc
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 23, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 12, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdbooth
Copy link
Contributor

mdbooth commented Apr 20, 2023

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Apr 20, 2023
@k8s-ci-robot
Copy link
Contributor

@mdbooth: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jichenjc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 11, 2023 •
edited
Loading

@jichenjc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
openstack-cloud-controller-manager-e2e-conformance-test 590d795 link true /test openstack-cloud-controller-manager-e2e-conformance-test
openstack-cloud-csi-manila-e2e-test 590d795 link true /test openstack-cloud-csi-manila-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mdbooth
Copy link
Contributor

mdbooth commented May 11, 2023

We closed the issue this relates to, so

/close

@k8s-ci-robot
Copy link
Contributor

@mdbooth: Closed this PR.

In response to this:

We closed the issue this relates to, so

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingxiankong lingxiankong lingxiankong requested changes

@ricolin ricolin Awaiting requested review from ricolin

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@lingxiankong lingxiankong

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin] Support VOLUME_CONDITION of CSI
6 participants
@jichenjc @k8s-ci-robot @lingxiankong @ramineni @k8s-triage-robot @mdbooth