Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[magnum-auto-healer] fix for stuck nodes in Ready,SchedulingDisabled after repair by reboot #2054

Closed
wants to merge 2 commits into from
Closed

[magnum-auto-healer] fix for stuck nodes in Ready,SchedulingDisabled after repair by reboot #2054

wants to merge 2 commits into from

Conversation

Kleku81
Copy link

@Kleku81 Kleku81 commented Dec 12, 2022 •
edited

What this PR does / why we need it:
is a proposal to solve the problem with worker nodes getting stuck in Ready,SchedulingDisabled after repair by reboot

Which issue this PR fixes(if applicable):
fixes #2053

Special notes for reviewers:
Build an image for magnum-auto-healer from the code with these changes, use this image in the magnum k8s cluster and simulate a failure on one of the cluster's working nodes, as follows:
sudo systemctl stop kubelet
and confirm that repair by reboot now works fine, and the problems described in issue #2053

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 12, 2022
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign openstacker for approval by writing /assign @openstacker in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 12, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @Kleku81!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Kleku81. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2022
@jichenjc
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 21, 2022
@mheler
Copy link

mheler commented Feb 9, 2023

any updates?

@jichenjc
Copy link
Contributor

jichenjc commented Feb 9, 2023

I am not expert at magnum-auto-headler...bug guess you need fix CLA first..

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 10, 2023
@k8s-ci-robot
Copy link
Contributor

@Kleku81: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
openstack-cloud-csi-manila-e2e-test eb451f2 link true /test openstack-cloud-csi-manila-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pawcykca
Copy link
Contributor

How can we fix the CLA and move on without any action from @Kleku81?

@jichenjc
Copy link
Contributor

How can we fix the CLA and move on without any action from @Kleku81?

pull the PR then resubmit ,and make Kleku81 as co-auther might work..

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 19, 2023
pawcykca added a commit to pawcykca/cloud-provider-openstack that referenced this pull request Jun 23, 2023
@pawcykca
Apply PR kubernetes#2054
c7cf1cf
@pawcykca pawcykca mentioned this pull request Jun 23, 2023
Merged
pawcykca added a commit to pawcykca/cloud-provider-openstack that referenced this pull request Jul 17, 2023
@pawcykca
Apply PR kubernetes#2054
9853d16
pawcykca added a commit to pawcykca/cloud-provider-openstack that referenced this pull request Jul 17, 2023
@pawcykca
Apply PR kubernetes#2054
a6ebccc
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pawcykca
Copy link
Contributor

Works on this case has been moved to PR 2279.

pawcykca added a commit to pawcykca/cloud-provider-openstack that referenced this pull request Jul 28, 2023
@pawcykca
Apply PR kubernetes#2054
0ef83d3 
Change fixed timeout value to parameter rebuild-delay-after-reboot

Replace deprecated wiat.Poll function

Refactoring and clean up code

Apply PR kubernetes#2054 and update
k8s-ci-robot pushed a commit that referenced this pull request Aug 21, 2023
@pawcykca
Apply PR #2054 (#2279)
66e06d1 
Change fixed timeout value to parameter rebuild-delay-after-reboot

Replace deprecated wiat.Poll function

Refactoring and clean up code

Apply PR #2054 and update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingxiankong lingxiankong Awaiting requested review from lingxiankong

@openstacker openstacker Awaiting requested review from openstacker

Assignees
No one assigned
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[magnum-auto-healer] Worker nodes get stuck in Ready,SchedulingDisabled after repair by reboot
6 participants
@Kleku81 @k8s-ci-robot @jichenjc @mheler @k8s-triage-robot @pawcykca