Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tags and vendor for 1.26 #2274

Merged
merged 2 commits into from
Jun 14, 2023
Merged

update tags and vendor for 1.26 #2274

merged 2 commits into from
Jun 14, 2023

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Jun 13, 2023 •
edited

needed for release 1.26.3

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 13, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 13, 2023
@zetaab
Copy link
Member Author

zetaab commented Jun 13, 2023

/test openstack-cloud-controller-manager-e2e-test-release-126
/test openstack-cloud-csi-manila-e2e-test-release-126
/test openstack-cloud-csi-cinder-sanity-test-release-126
/test openstack-cloud-csi-manila-sanity-test-release-126

@zetaab zetaab changed the title update tags and vendor update tags and vendor for 1.26 Jun 13, 2023
@zetaab
Copy link
Member Author

zetaab commented Jun 13, 2023

/test openstack-cloud-controller-manager-e2e-test-release-126
/test openstack-cloud-csi-manila-e2e-test-release-126
/test openstack-cloud-csi-cinder-sanity-test-release-126
/test openstack-cloud-csi-manila-sanity-test-release-126

@zetaab
Copy link
Member Author

zetaab commented Jun 13, 2023

cc @jichenjc

@zetaab
Copy link
Member Author

zetaab commented Jun 13, 2023

csi tests fails because the occm 1.26.3 does not exist (yet)

    "    Image:      registry.k8s.io/provider-os/openstack-cloud-controller-manager:v1.26.3",

Error from server (BadRequest): container "openstack-cloud-controller-manager" in pod "openstack-cloud-controller-manager-78dc8457f-5s72v" is waiting to start: trying and failing to pull image

@jichenjc
Copy link
Contributor

@zetaab so I assume we first get this in, then we should have 1.26.3 .. then we trigger another CI and lucky we should pass the CI for cinder?

@zetaab
Copy link
Member Author

zetaab commented Jun 14, 2023

Yup

@jichenjc
Copy link
Contributor

/override openstack-cloud-csi-cinder-e2e-test-release-126
/override openstack-cloud-csi-manila-e2e-test-release-126

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@jichenjc: Overrode contexts on behalf of jichenjc: openstack-cloud-csi-cinder-e2e-test-release-126, openstack-cloud-csi-manila-e2e-test-release-126

In response to this:

/override openstack-cloud-csi-cinder-e2e-test-release-126
/override openstack-cloud-csi-manila-e2e-test-release-126

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8e83c41 into kubernetes:release-1.26 Jun 14, 2023
10 checks passed
@zetaab zetaab deleted the updateta branch June 14, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

@lingxiankong lingxiankong Awaiting requested review from lingxiankong

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zetaab @jichenjc @k8s-ci-robot