Correct parsing of guestInfo metadata

[zerospiel]

What this PR does / why we need it:
Proper handling of encoded network for cloud-init in a VM's guestInfo.metadata

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #760

Special notes for your reviewer:

Release note:

Support for `base64` and `gzip+base64` encoding types in the `network` section of cloud-init config

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: zerospiel / name: Mikhail Morgoev (21992e3)

[k8s-ci-robot]

Hi @zerospiel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zerospiel]

cc @lubronzhan @sbueringer

[zerospiel]

cc @wyike PTAL

[wyike]

/ok-to-test

[wyike]

Thanks for your PR!

It looks good to me. I am just curious what mechanism you're using to bootstrap a cluster (cluster api or something else?)and then there is a network.encoding wrote to the cloud init data?

By the way, would you add a release note, thanks!

[zerospiel]

@wyike Thanks! I updated the initial comment with the note.

I was using a deeply modified (could be considered as from scratch) version of cluster-api, when a machine's guest info meta had base64-encoded netplan config on purpose. And since that behavior is supported, then why don't use it, right? The codebase though couldn't have been changed because of supporting that "old" behavior in already existing clusters

[wyike]

Thanks for the details!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wyike, zerospiel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wyike]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment