Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle volume scheduling when nodes are shutdown #31

Closed
yastij opened this issue May 16, 2019 · 6 comments
Closed

Handle volume scheduling when nodes are shutdown #31

yastij opened this issue May 16, 2019 · 6 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. P2 Priority 2
Milestone

Comments

@yastij
Copy link
Member

yastij commented May 16, 2019

Currently if a node gets shutdown, pods using volumes don't get rescheduled, Since we don't know if the volumes are still being used.

Two solutions:

  • Create a flow that has an interlock between node lifecycle controller, taintManager, PodGC, attach_detach_controller and kubelet, one of the drawbacks of this solution is that we need to tie taint removal to finishing the eviction (more specifically to finishing volume detach)

  • Rely on nodeReadiness Gate and let cloud provider implement a node condition shutdown, act upon it to detach the volume and remove it, one of the drawbacks of relying on condition is that we cannot tolerate them.

cc'ing folks involved for thoughts @smarterclayton @liggitt @andrewsykim @jingxu97 and @yujuhong

/assign

@yastij yastij changed the title Handle nodes that shutdown Handle nodes that are shutdown May 16, 2019
@andrewsykim andrewsykim added this to the Next milestone May 16, 2019
@andrewsykim
Copy link
Member

KEP kubernetes/enhancements#1116

@andrewsykim andrewsykim modified the milestones: Next, v1.16 Jul 10, 2019
@andrewsykim andrewsykim added the P1 Priority 1 label Jul 10, 2019
@andrewsykim andrewsykim changed the title Handle nodes that are shutdown Handle volume scheduling when nodes are shutdown Oct 2, 2019
@andrewsykim andrewsykim modified the milestones: v1.16, Next Oct 2, 2019
@andrewsykim andrewsykim added P2 Priority 2 and removed P1 Priority 1 labels Oct 2, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2019
@yastij
Copy link
Member Author

yastij commented Jan 3, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2020
@andrewsykim
Copy link
Member

/close

This probably belongs in SIG node going forward

@k8s-ci-robot
Copy link
Contributor

@andrewsykim: Closing this issue.

In response to this:

/close

This probably belongs in SIG node going forward

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jaidevmane pushed a commit to jaidevmane/cloud-provider that referenced this issue Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. P2 Priority 2
Projects
None yet
Development

No branches or pull requests

4 participants