Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all repos have the CoC #3053

Closed
nikhita opened this issue Dec 27, 2018 · 6 comments
Closed

Ensure all repos have the CoC #3053

nikhita opened this issue Dec 27, 2018 · 6 comments
Labels
committee/code-of-conduct Denotes an issue or PR intended to be handled by the code of conduct committee. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@nikhita
Copy link
Member

nikhita commented Dec 27, 2018

I wrote up some quick Go code for identifying repos that don't have the CONTRIBUTING.md file for kubernetes/steering#28. Used the same one for finding missing LICENSE files (kubernetes/steering#57 (comment)) and CoC.

The following repos don't have the file code-of-conduct.md at their root:

kubernetes:
kubernetes/website
kubernetes/klog
kubernetes/cloud-provider-sample

kubernetes-sigs:
kubernetes-sigs/aws-alb-ingress-controller
kubernetes-sigs/aws-iam-authenticator
kubernetes-sigs/mutating-trace-admission-controller

We should probably automate this like secping? Thoughts about how to go about this? I see two options right now:

/cc @cblecker @fejta @spiffxp @BenTheElder @jessfraz
/sig contributor-experience
/committee conduct

@BenTheElder
Copy link
Member

SGTM 👍
No real opinions on the tool itself, whatever @jessfraz prefers regarding secping.
If we can write less new code, great! 💯 If not, it wouldn't be much more new code in test-infra 🙃

@fejta
Copy link
Contributor

fejta commented Jan 7, 2019

Using her code sgtm, but I think the tool should have a different name than secping, although it wouldn't be the end of the world if that happens.

@nikhita
Copy link
Member Author

nikhita commented Mar 18, 2019

/kind feature
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Mar 18, 2019
@nikhita
Copy link
Member Author

nikhita commented Mar 18, 2019

Come to think of it...I don't think we need a tool for the CoC anymore. All new repos are created by the github-mangement team and the initial commit is from https://github.com/kubernetes/kubernetes-template-project (which contains the CoC). We won't need this unless someone removes the CoC explicitly - which I don't think will happen.

Closing this. Please reopen if needed.
/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closing this issue.

In response to this:

Come to think of it...I don't think we need a tool for the CoC anymore. All new repos are created by the github-mangement team and the initial commit is from https://github.com/kubernetes/kubernetes-template-project (which contains the CoC). We won't need this unless someone removes the CoC explicitly - which I don't think will happen.

Closing this. Please reopen if needed.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
committee/code-of-conduct Denotes an issue or PR intended to be handled by the code of conduct committee. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Development

No branches or pull requests

4 participants