Add instructions on how to setup the CNCF CLA check #1649
Conversation
k8s-ci-robot
added
size/M
|
/lgtm @spiffxp thanks for collecting this! |
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
LGTM |
|
@spiffxp is the root of the repo the best place for this? |
|
@cblecker agreed, in general there's a lot of stuff lurking in root that seems like it should go elsewhere but... naming is hard for me today, so I'm very open to suggestion ie: burying in a sig/wg/committee folder seemed wrong, contributors/devel didn't seem right either, and I didn't want to shuffle around a whole bunch of docs into a new folder as part of this pr |
|
@spiffxp Makes sense. Then yeah, I'm okay with this for now. I'll think on this, as yeah, there are other docs like sysadmin.md that should kind of be grouped together under like.. community administration |
setting-up-cla-check.md
Outdated
| - `comment=no` specifies that our system should not post help comments into the pull request (since the Kubernetes mungebot does this). | ||
| - `target=https://identity.linuxfoundation.org/projects/cncf` specifies what will be used for the "Details" link in Github for this status check. | ||
| - Content Type: application/json | ||
| - Secret: Please contact one of [@idvoretskyi](https://github.com/idvoretskyi), [@foxish](https://github.com/foxish), or [@spiffxp](https://github.com/spiffxp) |
There was a problem hiding this comment.
When I previously spoke with Ihor he said the POCs for this were himself and Chris Aniszczyk. Is this an updated list from that?
There was a problem hiding this comment.
@mattfarina That's fine, I'm handling the questions of CLA for Kubernetes on behalf of CNCF.
There was a problem hiding this comment.
Well, it was more that I know foxish and I have the secret (he's who ihor referred me to when I asked), and wanted to avoid a bottleneck here, but upon further thought it's probably wiser to keep that secret with them.
spiffxp
force-pushed
the
setting-up-the-cla-check
branch
from
ccf460b
to
0b1260d
Compare
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @idvoretskyi @spiffxp |
k8s-github-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: idvoretskyi, spiffxp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
This is pretty much rote copy-paste from a google doc I got from @foxish.
I followed these instructions as part of kubernetes-retired/testing_frameworks#3
/cc @mattfarina @foxish @idvoretskyi
since I mentioned this to you
FYI @kubernetes/sig-testing-pr-reviews
This could stand to be streamlined, any suggestions?