Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeadm configfile beta - add documentation for images #2513

Conversation

fabriziopandini
Copy link
Member

As requested in this comment, this PR adds documentation about how to update / edit images linked from KEP0023 - Kubeadm configfile beta

/CC @timothysc @liztio

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 10, 2018
@rosti
Copy link

rosti commented Aug 10, 2018

Perhaps s/master/control-plane/g?

participant "node\n(api object)" as n

u->k: UpgradeConfiguration
note over u, n:Upgrade configuration should allow only well-know changes to the cluster e.g. change of custom images if used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well-know -> well known

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. change -> , e.g. the change

kpcm->k:
k->k:update KubeProxy\ncomponent config\nusing api machinery
k->kpcm:save updated KubeProxy component config
note over kpcm, n:the updaed KubeProxy component config will\nbe used by the updated kube-proxy DaemonsSet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DaemonsSet -> DaemonSet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updaed -> updated

participant "kubeproxy-config\nConfigMap" as kpcm
participant "kubelet-config\nConfigMap-1.*" as kcm

u->k:provide\nInitConfiguration (with NodeRegistrationOptions, Master)\nClusterConfiguration\nKubeProxy component config\nKubelet component config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubelet -> kubelet
(case-sensitive search-and-replace would solve as there are more than one instances.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component config -> component configuration?
(present in other places too)


k->cm:read ClusterConfiguration
cm->k:
k->cm:remove Master\nfrom ClusterConfiguration.Status\n(only if the node is master)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is master -> is a Control Plane node

k->kk:write NodeRegistrationOptions\nto /var/lib/kubelet/kubeadm-flags.env
kk->n:start node

note over kcm, n:the updated Kubelet component config\nwill be used by other nodes\nby running\nkubeadm upgrade nodes locally
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\nby running -> \nwhen running

## kubeadm upgrade node

```
title kubeadm upgrade node (interactions with v1beta1 config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1beta1 config -> the v1beta1 configuration

## kubeadm upgrade

```
title kubeadm upgrade apply (interactions with v1beta1 config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1beta1 -> the v1beta1 configuration

## kubeadm reset

```
title kubeadm reset (interactions with v1beta1 config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1beta1 config -> the v1beta1 configuration

@neolit123
Copy link
Member

thanks for the writeup @fabriziopandini 👍
please feel to ignore some of the comments if you think the current text is better, as is.

@fabriziopandini fabriziopandini force-pushed the kubeadm-configfile-beta-documentation branch from d81f869 to c975a70 Compare August 11, 2018 06:21
@fabriziopandini
Copy link
Member Author

@neolit123 @rosti Many thanks for the feedbacks!
Everything is addressed; new images are regenerated accordingly.

@liztio
Copy link
Contributor

liztio commented Aug 13, 2018

Thanks for this documentation @fabriziopandini! Super helpful to make this be more editable by other people.

@fabriziopandini
Copy link
Member Author

/assign @timothysc

Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in and if needed refine more in 1.13

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit ee5f12e into kubernetes:master Aug 22, 2018
calebamiles pushed a commit to calebamiles/community that referenced this pull request Sep 5, 2018
…gfile-beta-documentation

Kubeadm configfile beta - add documentation for images
@fabriziopandini fabriziopandini deleted the kubeadm-configfile-beta-documentation branch September 6, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants