Move the ComponentConfig types to staging KEP to implementable #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
sig/cluster-lifecycle
k8s-ci-robot
added
sig/api-machinery
k8s-ci-robot
added
the
cncf-cla: yes
15 tasks
|
From sig cloud-provider pov, these updates look fine to me. I'll defer to anything that @andrewsykim or @jagosan pick up on, though. |
sttts
reviewed
Aug 16, 2018
| * Set up staging publishing bot (async, non-critical) | ||
| * The kubelet, kube-proxy and controller-manager follow, each one independently. | ||
| * The kubelet, kube-proxy and kube-controller-manager types follow, each one independently. |
There was a problem hiding this comment.
kube+cloud-controller-manager
|
Looks good. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
calebamiles
pushed a commit
to calebamiles/community
that referenced
this pull request
Sep 5, 2018
Move the ComponentConfig types to staging KEP to implementable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor changes to the initial KEP after further discussions in the sig-api-machinery Slack channel.
Builds on top of #2354 and marks it as
implementable.We have now submitted and merged the ~5 first PRs of this effort, with more PRs planned and in the reviewing stage. We hope to get all of this implemented by v1.12 code freeze.
The additions to this version is that we've decided on a defaulting story, and know a bit more about the actual implementation plan, and know what tests to write up for the MVP.
Again, mentioning the SIGs that are affected by this proposal:
@kubernetes/sig-cluster-lifecycle-pr-reviews @kubernetes/sig-api-machinery-pr-reviews @kubernetes/sig-architecture-api-reviews @kubernetes/sig-node-pr-reviews @kubernetes/sig-cloud-provider-pr-reviews @kubernetes/sig-scheduling-pr-reviews @kubernetes/sig-network-pr-reviews
/assign @thockin @jbeda @liggitt @bgrant0607 @mtaufen @wojtek-t