Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune sig-testing github teams #2541

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 15, 2018

I anticipate it will be some time before a team structure for all sigs is driven to conclusion #2323

In the meantime, I'd like to go ahead and prune sig-testing's teams manually:

  • Rename sig-testing-misc to sig-testing
  • Leave sig-testing-pr-reviews since I recall seeing that used when devstats was tracking this stuff

Everyone who's a member of the other teams is already a member of sig-testing-misc, so there will be no team membership changes.

NOTE: merging this does not actually remove the teams, it's something I will manually do as a request to kubernetes/org

Rename sig-testing-misc to sig-testing

Leave sig-testing-pr-reviews since I recall seeing that used when
devstats was tracking this stuff
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 15, 2018
@cblecker
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Aug 15, 2018

GitHub queries for teams I propose we prune:

GitHub queries for teams I propose we keep:

@spiffxp
Copy link
Member Author

spiffxp commented Aug 15, 2018

/hold
for any objections from the following
/cc @rmmh @BenTheElder @fejta @cjwagner @ixdy @mkumatag
Lazy consensus. Please raise any objections before tomorrow

@spiffxp
Copy link
Member Author

spiffxp commented Aug 15, 2018

/uncc @calebamiles

@k8s-ci-robot k8s-ci-robot removed the request for review from calebamiles August 15, 2018 17:31
@mkumatag
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Aug 16, 2018

/hold cancel
lazy consensus

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6d9b65a into kubernetes:master Aug 16, 2018
@spiffxp spiffxp deleted the prune-sig-testing-teams branch August 16, 2018 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants