Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stakeholder sigs for wg-k8s-infra #3135

Merged
merged 1 commit into from Jan 23, 2019
Merged

Add stakeholder sigs for wg-k8s-infra #3135

merged 1 commit into from Jan 23, 2019

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jan 22, 2019

Side note: now that I've done this, I sorta wish we changed the field to
instead take keys that corresponded to the other entries in sigs.yaml.
Could be validated, and names wouldn't need to be repeated. But first,
the content.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 22, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Jan 22, 2019

/wg k8s-infra

cblecker
cblecker approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on behalf of ContribEx
cc: @nikhita

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Member

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 23, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Jan 23, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Jan 23, 2019

If I can't PR in my suggestion for "use keys instead of words" I'll issue it up later today

@k8s-ci-robot k8s-ci-robot merged commit 7264f80 into kubernetes:master Jan 23, 2019
@spiffxp spiffxp deleted the stakeholder-sigs-wg-k8s-infra branch January 23, 2019 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker approved these changes

@idvoretskyi idvoretskyi Awaiting requested review from idvoretskyi

@jdumars jdumars Awaiting requested review from jdumars

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spiffxp @k8s-ci-robot @cblecker