Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Documentation for Non-Code Contributions Guide and Meeting #3195

Merged
merged 3 commits into from Feb 5, 2019
Merged

Update Documentation for Non-Code Contributions Guide and Meeting #3195

merged 3 commits into from Feb 5, 2019

Conversation

qedrakmar
Copy link
Member

Includes community feedback in the existing non-code role listing, and also provides a link to that listing from the Contributor Guide.

This also resolves #3158 by adding the meeting under the contributor documentation subproject in sigs.yaml.

/sig contributor-experience

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/contributor-guide Issues or PRs related to the contributor guide labels Feb 4, 2019
@qedrakmar
Copy link
Member Author

I would also like @eduartua to take a look and make sure I haven't stepped on any contributor guide style-guidelines in my haste.

@eduartua
Copy link
Member

eduartua commented Feb 4, 2019

Looks good to me.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2019
idvoretskyi
idvoretskyi approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, idvoretskyi, qedrakmar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cblecker,idvoretskyi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cc53611 into kubernetes:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@cblecker cblecker cblecker approved these changes

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@idvoretskyi idvoretskyi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/contributor-guide Issues or PRs related to the contributor guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-code contributors meeting isn't listed in sig-contributor-experience's README
5 participants
@qedrakmar @eduartua @k8s-ci-robot @idvoretskyi @cblecker