New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation for Non-Code Contributions Guide and Meeting #3195

Merged
merged 3 commits into from Feb 5, 2019

Conversation

@qedrakmar
Copy link
Contributor

qedrakmar commented Feb 4, 2019

Includes community feedback in the existing non-code role listing, and also provides a link to that listing from the Contributor Guide.

This also resolves #3158 by adding the meeting under the contributor documentation subproject in sigs.yaml.

/sig contributor-experience

qedrakmar added some commits Feb 3, 2019

Added community input to the non-code-contributions guide, and added …
…a link to that guide from the Contributor Guide.
@qedrakmar

This comment has been minimized.

Copy link
Contributor Author

qedrakmar commented Feb 4, 2019

I would also like @eduartua to take a look and make sure I haven't stepped on any contributor guide style-guidelines in my haste.

@eduartua

This comment has been minimized.

Copy link
Contributor

eduartua commented Feb 4, 2019

Looks good to me.

@idvoretskyi
Copy link
Member

idvoretskyi left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 5, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, idvoretskyi, qedrakmar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cblecker,idvoretskyi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cc53611 into kubernetes:master Feb 5, 2019

3 checks passed

cla/linuxfoundation qedrakmar authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment