Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes contributors guide pull request doc #3087 #3548

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Fixes contributors guide pull request doc #3087 #3548

merged 1 commit into from
Apr 5, 2019

Conversation

Sai-Adarsh
Copy link
Contributor

@Sai-Adarsh Sai-Adarsh commented Apr 2, 2019 •
edited

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Sai-Adarsh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/contributor-guide Issues or PRs related to the contributor guide area/developer-guide Issues or PRs related to the developer guide sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Apr 2, 2019
@guineveresaenger
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2019
guineveresaenger
guineveresaenger approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help with this!

@guineveresaenger
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2019
@guineveresaenger
Copy link
Contributor

/approve

(not sure I have approver powers)

@guineveresaenger
Copy link
Contributor

cc @nikhita or @parispittman for approval

@nikhita
Copy link
Member

nikhita commented Apr 3, 2019

Could you update the commit message to describe what is being changed? It's helpful to understand while doing a git blame :)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2019
@Sai-Adarsh
Copy link
Contributor Author

Could you update the commit message to describe what is being changed? It's helpful to understand while doing a git blame :)

@nikhita done!

nikhita
nikhita approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @Sai-Adarsh!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2019
@nikhita
Copy link
Member

nikhita commented Apr 4, 2019

/assign @castrojo
for approval

@castrojo
Copy link
Member

castrojo commented Apr 5, 2019

/approve

Thanks for your revisions, and welcome to Kubernetes!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo, guineveresaenger, nikhita, Sai-Adarsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 455bf27 into kubernetes:master Apr 5, 2019
@Sai-Adarsh
Copy link
Contributor Author

Thanks, @guineveresaenger @nikhita @castrojo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guineveresaenger guineveresaenger guineveresaenger approved these changes

@nikhita nikhita nikhita approved these changes

@castrojo castrojo Awaiting requested review from castrojo

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@spiffxp spiffxp

@castrojo castrojo

@guineveresaenger guineveresaenger

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/contributor-guide Issues or PRs related to the contributor guide area/developer-guide Issues or PRs related to the developer guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Sai-Adarsh @k8s-ci-robot @guineveresaenger @nikhita @castrojo @spiffxp