Documment logging formats #6255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
pohly
suggested changes
Nov 30, 2021
|
Looks good, thanks for capturing this. |
serathius
force-pushed
the
logging-formats
branch
from
3117f55
to
c430dcb
Compare
k8s-ci-robot
added
size/M
serathius
force-pushed
the
logging-formats
branch
from
c430dcb
to
eee16c8
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@pohly addressed all comments. |
Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>
serathius
force-pushed
the
logging-formats
branch
from
eee16c8
to
1317bc7
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During recent WG Structured Logging meeting we went into discussion what features/changes should be make in specific problem. This lead us to agree that we need some high level guide about what changes make sense in which format.
This is draft PR that I started writing to document goals of each logging format.
/cc @ehashman @pohly