Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update org member requirements #7380

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Update org member requirements #7380

merged 2 commits into from
Jul 10, 2023

Conversation

mrbobbytables
Copy link
Member

This PR does 2 things:

  • Reduces duration of inactive member policy from 18 to 12 months (current audit has over 600 members that have had 0 contributions in the past year)
  • Clarifies the org membership requirements to highlight that the contributions must demonstrate an ongoing and long-term commitment to the project.

/committee steering
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. committee/steering Denotes an issue or PR intended to be handled by the steering committee. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 30, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2023
@aojea
Copy link
Member

aojea commented Jul 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2023
cpanato
cpanato approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rikatz
Copy link
Contributor

rikatz commented Jul 3, 2023

👋
While I agree 99% with all the requirements, I would like to understand how Emeritus status would work :)

I think we have many Emeritus people that contributed to Kubernetes for a long time and even gave the shape that we are today, but have stepped down due to personal reasons, a change of work scope, or even retirement. We know who are those people, we even add them as EMERITUS on our OWNER and OWNER_ALIASES :)

I have the feeling that removing their membership org seems not right, and instead, we should have mapped that Emeritus, per their contributions on past will have their status kept :)

@cpanato
Copy link
Member

cpanato commented Jul 3, 2023

I would agree with @rikatz

@mrbobbytables
Copy link
Member Author

I have the feeling that removing their membership org seems not right, and instead, we should have mapped that Emeritus, per their contributions on past will have their status kept :)

FWIW one of our long-standing (although low priority) requests to GitHub is for a badge of some kind. A way for us to recognize that they were a contributor and show up on their profile that doesn't map to an org.

I do understand the desire to let them stay as org members and have that 'badge', but there have been a few issues with letting people stay around forever. First big thing org membership comes with elevated permissions and responsibilities that REALLY should be reserved for people that are actively contributing to the project. Often them getting removed from the org is the signal to clean them up from OWNERS (thats a related, but separate problem -_-).

I also don't want to call out individuals, but something else we have seen is someone that has largely been afk for ages come back for a random lgtm or approve for a coworker. I have personally dm'ed people about this.

If a person is an emeritus approver and removed from the org but becomes active again they can point to the owners file with them as an emeritus approver to fast track becoming an org member again.

Aging out should be considered a part of the 'contributor lifecycle', recognition is good - but the overall health of the project should be the priority.

@rikatz
Copy link
Contributor

rikatz commented Jul 3, 2023

Ah it totally makes sense Bob! Thanks for clarifying it :)

MadhavJivrajani
MadhavJivrajani reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion.
LGTM otherwise, thank you @mrbobbytables! ❤️

community-membership.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2023
MadhavJivrajani
MadhavJivrajani approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
With ContribEx hat on.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2023
pnbrown
pnbrown approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@pnbrown pnbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these clarifications are very helpful

nikhita
nikhita approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

palnabarun
palnabarun approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
(with the GitHub admin + ContribEx hat)

/lgtm
(with the steering hat)

@palnabarun
Copy link
Member

palnabarun commented Jul 6, 2023 •
edited by mrbobbytables

Steering Approvals:

@palnabarun
Copy link
Member

@mrbobbytables -- since you proposed the changes, I am guessing this is an explicit approval from your side.

@cpanato -- Can you please confirm again if you lgtm'ed with your steering hat on?

@mrbobbytables
Copy link
Member Author

Yup, I definitely approve 👍

@cpanato
Copy link
Member

cpanato commented Jul 6, 2023

with steering hat:
/lgtm

justaugustus
justaugustus approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm (Steering)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, MadhavJivrajani, mrbobbytables, nikhita, palnabarun, pnbrown, txn55

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MadhavJivrajani,cpanato,justaugustus,mrbobbytables,nikhita,palnabarun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Member

/lgtm

@tpepper
Copy link
Member

tpepper commented Jul 10, 2023

/lgtm

@mrbobbytables
Copy link
Member Author

We have acks from all of steering, releasing the hold. Thanks all!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1a80343 into kubernetes:master Jul 10, 2023
3 checks passed
@mrbobbytables mrbobbytables deleted the membership branch October 31, 2023 14:10
@palnabarun palnabarun mentioned this pull request Jan 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@cpanato cpanato cpanato approved these changes

@palnabarun palnabarun palnabarun approved these changes

@pnbrown pnbrown pnbrown approved these changes

@MadhavJivrajani MadhavJivrajani MadhavJivrajani approved these changes

@nikhita nikhita nikhita approved these changes

@txn55 txn55 txn55 approved these changes

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@cblecker cblecker

@tpepper tpepper

@cpanato cpanato

@aojea aojea

@palnabarun palnabarun

@MadhavJivrajani MadhavJivrajani

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet