Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sig-auth TL #7590

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Update sig-auth TL #7590

merged 1 commit into from
Oct 31, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 30, 2023

Updating sig-auth to rotate @mikedanese out of TL and @enj in.

Many thanks, Mike! Congrats, Mo!

https://groups.google.com/a/kubernetes.io/g/dev/c/YbcO8tEk82U

/hold for acks
/sig auth
/committee steering
/assign @deads2k @ritazh @mikedanese @enj

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2023
@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Oct 30, 2023
@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Oct 30, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2023
enj
enj reviewed Oct 30, 2023
View reviewed changes
sigs.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2023
@enj
Copy link
Member

enj commented Oct 30, 2023

LGTM 😄

@ritazh
Copy link
Member

ritazh commented Oct 30, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2023
@deads2k
Copy link
Contributor

deads2k commented Oct 30, 2023

/lgtm
/approve

@liggitt
Copy link
Member Author

liggitt commented Oct 30, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2023
@liggitt
Copy link
Member Author

liggitt commented Oct 30, 2023

Once this PR has been reviewed and has the lgtm label, please assign pohly for approval

/assign @pohly

pohly
pohly approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt, pohly, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit d411b7b into kubernetes:master Oct 31, 2023
3 checks passed
@mikedanese
Copy link
Member

LGTM! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj enj left review comments

@pohly pohly pohly approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@pohly pohly

@mikedanese mikedanese

@ritazh ritazh

@enj enj

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@liggitt @enj @ritazh @deads2k @k8s-ci-robot @mikedanese @pohly