-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contributors: Add SIG ContribEx as owners #7930
Conversation
Signed-off-by: Stephen Augustus <foo@auggie.dev>
/hold until SIG ContribEx reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
with SIG ContribEx hat on
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, MadhavJivrajani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/hold |
For other leads in case they have any comments, can unhold after one more ack. |
Ah, didn't notice that my PR was set for the steering committee to review, whoops. Sorry about that. Btw, in case someone (else) wants to merge it feel free, we have had some people wonder how to sign the CLA when they start contributing :) |
/lgtm (as ContribEx TL) /unhold |
@kubernetes/sig-contributor-experience-leads — I've noticed a few PRs e.g., #7691, #7923 that are flagging @kubernetes/steering-committee members for review, when we likely don't need to be in the path.
Raising this PR draw attention to the approval gap.
Let me know if you want me to extend it to other directories or if you're happy to carry any updates as follow-ups.