Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sftim to approvers #326

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Add sftim to approvers #326

merged 1 commit into from
Aug 12, 2022

Conversation

jberkus
Copy link
Contributor

@jberkus jberkus commented Aug 2, 2022

This adds @sftim to the list of approvers for Contributor Site.

Tim has been editing contributor site blog posts for the last several months. It'll be useful if he can approve them as well, given timing issues.

Attn: @mrbobbytables @jeefy

so that he can commit blog posts

Signed-off-by: Josh Berkus <josh@agliodbs.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from jeefy August 2, 2022 23:17
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@sftim
Copy link
Contributor

sftim commented Aug 12, 2022

/lgtm

I'm happy with this change.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 82ea9f0 into kubernetes:master Aug 12, 2022
@jberkus jberkus deleted the addtim branch September 8, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants