Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog post introducing kwok #377

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Blog post introducing kwok #377

merged 1 commit into from
Feb 28, 2023

Conversation

wzshiming
Copy link
Member

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2023
@wzshiming wzshiming changed the title [WIP] Add blog post for introdution kwok [WIP] Add blog post for introduction kwok Feb 24, 2023
sftim
sftim reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image size fix feels important. Rest of the article LGTM; fixups and tweaks are still welcome.

content/en/blog/2023/2023-03-01-introducing-kwok/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/2023-03-01-introducing-kwok/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/2023-03-01-introducing-kwok/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/2023-03-01-introducing-kwok/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/2023-03-01-introducing-kwok/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/2023-03-01-introducing-kwok/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/2023-03-01-introducing-kwok/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/2023-03-01-introducing-kwok/index.md Outdated Show resolved Hide resolved
@wzshiming wzshiming force-pushed the blog/introducing-kwok branch 2 times, most recently from 72c340e to e760d90 Compare February 24, 2023 14:30
@sftim
Copy link
Contributor

sftim commented Feb 27, 2023

/retitle [WIP] Add blog post for introducing kwok

Informally LGTM (I'll try to take more of a look later)

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Add blog post for introduction kwok [WIP] Add blog post for introducing kwok Feb 27, 2023
@wzshiming @Huang-Wei @sftim
Add blog post for introdution kwok
b7e8227 
Co-authored-by: Wei Huang <weih@hey.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@wzshiming wzshiming mentioned this pull request Feb 28, 2023
Merged
@wzshiming
Copy link
Member Author

/cc @Huang-Wei

@Huang-Wei
Copy link
Member

@wzshiming I haven't compared the content with the k/website one thoroughly. As long as the mirrored version resolved all the comments, I'm fine with this PR as well.

@wzshiming
Copy link
Member Author

Yes, both are the same.

@sftim
Copy link
Contributor

sftim commented Feb 28, 2023

Is this still a work in progress? What needs to happen before it's ready to review?

@Huang-Wei
Copy link
Member

Is this still a work in progress? What needs to happen before it's ready to review?

It's ready for reviewing.

/retitle Blog post introducing kwok

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Add blog post for introducing kwok Blog post introducing kwok Feb 28, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2023
sftim
sftim reviewed Feb 28, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

The filename should actually be content/en/blog/2023/introducing-kwok/index.md

I'll send in a PR to fix that.

content/en/blog/2023/2023-03-01-introducing-kwok/index.md
slug: introducing-kwok
---

**Author:** Shiming Zhang (DaoCloud), Wei Huang (Apple), Yibo Zhuang (Apple)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Author:** Shiming Zhang (DaoCloud), Wei Huang (Apple), Yibo Zhuang (Apple)
**Authors:** Shiming Zhang (DaoCloud), Wei Huang (Apple), Yibo Zhuang (Apple)

sftim
sftim reviewed Feb 28, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@sftim
Copy link
Contributor

sftim commented Feb 28, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit addb0e8 into kubernetes:master Feb 28, 2023
@wzshiming wzshiming deleted the blog/introducing-kwok branch March 1, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jberkus jberkus Awaiting requested review from jberkus

@jeefy jeefy Awaiting requested review from jeefy

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wzshiming @sftim @Huang-Wei @k8s-ci-robot