-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post introducing kwok #377
Blog post introducing kwok #377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image size fix feels important. Rest of the article LGTM; fixups and tweaks are still welcome.
72c340e
to
e760d90
Compare
/retitle [WIP] Add blog post for introducing kwok Informally LGTM (I'll try to take more of a look later) |
Co-authored-by: Wei Huang <weih@hey.com> Co-authored-by: Tim Bannister <tim@scalefactory.com>
a04b36d
to
b7e8227
Compare
/cc @Huang-Wei |
@wzshiming I haven't compared the content with the k/website one thoroughly. As long as the mirrored version resolved all the comments, I'm fine with this PR as well. |
Yes, both are the same. |
Is this still a work in progress? What needs to happen before it's ready to review? |
It's ready for reviewing. /retitle Blog post introducing kwok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
The filename should actually be content/en/blog/2023/introducing-kwok/index.md
I'll send in a PR to fix that.
slug: introducing-kwok | ||
--- | ||
|
||
**Author:** Shiming Zhang (DaoCloud), Wei Huang (Apple), Yibo Zhuang (Apple) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Author:** Shiming Zhang (DaoCloud), Wei Huang (Apple), Yibo Zhuang (Apple) | |
**Authors:** Shiming Zhang (DaoCloud), Wei Huang (Apple), Yibo Zhuang (Apple) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim, wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
mirror from kubernetes/website#39653