Skip to content

Commit

Permalink
Add image_id to CRI ContainerStatus message
Browse files Browse the repository at this point in the history
There is a conversion function `ConvertPodStatusToRunningPod`, which
can override the `Container.ImageID` into a digested reference from the
`ContainerStatus` CRI RPC, which gets mapped from the `image_ref`:

https://github.com/kubernetes/kubernetes/blob/411c29c39f03687a30a8667295c61590def8fc89/pkg/kubelet/container/helpers.go#L259-L292

To avoid that failure case, we now introduce the same `image_id` into
the container status and let runtimes separate the fields.

We also add a note that the mapping from the digested reference of the
CRI to the Kubernetes Pod API `ImageID` field is intentional and should
not change.

Follow-up on: kubernetes/kubernetes#123508

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>

Kubernetes-commit: e38531e9a2359c2ba1505cb04d62d6810edc616e
  • Loading branch information
saschagrunert authored and k8s-publishing-bot committed Feb 29, 2024
1 parent 882719b commit 63929b3
Show file tree
Hide file tree
Showing 2 changed files with 509 additions and 439 deletions.
Loading

0 comments on commit 63929b3

Please sign in to comment.