Create namespace dialog bugfix (production) #167
Conversation
| @@ -28,7 +28,23 @@ export default function showNamespaceDialog(mdDialog, event, namespaces) { | |||
| controllerAs: 'ctrl', | |||
| clickOutsideToClose: true, | |||
| targetEvent: event, | |||
| templateUrl: '/deploy/createnamespace.html', | |||
| template: `<md-dialog aria-label="Create a new namespace" layout="column" layout-padding> | |||
There was a problem hiding this comment.
Leave the html template file and just change /deploy/createnamespace.html to deploy/createnamespace.html. This should work.
|
Good catch. Just add |
|
Ok. thank you 👍 |
taimir
force-pushed
the
create_namespace_bugfix
branch
from
d1aa006
to
ede11ab
Compare
|
PTAL, should be ready for merge. |
| @@ -58,6 +58,7 @@ export default class NamespaceDialogController { | |||
| cancel() { this.mdDialog_.cancel(); } | |||
|
|
|||
| /** | |||
| * @export | |||
| * Creates new namespace based on the state of the controller. | |||
| */ | |||
There was a problem hiding this comment.
Everywhere else @export and @private is the last line of comment so maybe switch this to be consistent.
|
Add |
taimir
force-pushed
the
create_namespace_bugfix
branch
2 times, most recently
from
d89b231
to
2ae6e59
Compare
|
OK, just made it consistent. BTW, I notice the empty lines between the comment text and annotations are not really consistent throughout the code... Could we somehow unify this (agree on some rule)? |
|
I agree, we should write this things down in some dev guide. |
taimir
force-pushed
the
create_namespace_bugfix
branch
from
2ae6e59
to
7492998
Compare
|
Thank you for this fix! We need to come up with a clever way to verify this during QA. In other projects I've worked on we required to send a live production demo of a change. But this is hard in open source... Let's talk about this tomorrow. |
Create namespace dialog bugfix (production)
This is not meant to be merged immediately.
There is currently a bug when running 'gulp serve:prod' - the namespace creation dialog in the deploy view does not respond (the dialog window does not open). Now looking at it, this was because of the following two issues:
Pasting the template directly as shown here works, and this is a quick-fix workaround. Nevertheless, could anyone propose a better method of handling this?