Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote sidecar url #3960

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Conversation

jeefy
Copy link
Member

@jeefy jeefy commented Jun 23, 2019

Fixes #3957

URL structure is not the same between Heapster and Sidecar, so that was an artifact.

Props to @kadenlnelson for finding the problem :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeefy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2019
@ghost
Copy link

ghost commented Jun 23, 2019

As long as it's been tested, LGTM

@jeefy jeefy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7d6685d into kubernetes:master Jun 25, 2019
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #3960 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3960      +/-   ##
==========================================
- Coverage   47.29%   47.28%   -0.02%     
==========================================
  Files         182      182              
  Lines        8403     8403              
  Branches       72       72              
==========================================
- Hits         3974     3973       -1     
- Misses       4184     4185       +1     
  Partials      245      245
Impacted Files Coverage Δ
...c/app/backend/integration/metric/sidecar/client.go 72% <100%> (ø) ⬆️
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c009fd...387bb69. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dashboard is unable to display metrics when metrics scraper is deployed alongside the dashboard as a "sidecar"
2 participants