Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FR i18n #4697

Merged
merged 2 commits into from
Dec 22, 2019
Merged

Update FR i18n #4697

merged 2 commits into from
Dec 22, 2019

Conversation

feloy
Copy link
Member

@feloy feloy commented Dec 21, 2019

refs #4259

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. language/fr Updates or issues for French translations. labels Dec 21, 2019
@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #4697 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4697      +/-   ##
==========================================
- Coverage   45.39%   45.38%   -0.02%     
==========================================
  Files         214      214              
  Lines        9976     9976              
  Branches       96       96              
==========================================
- Hits         4529     4528       -1     
- Misses       5181     5182       +1     
  Partials      266      266
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d66fc0...cac1a7a. Read the comment docs.

@shu-mutou
Copy link
Contributor

/hold
Please check and wait for merging #4700. Then rebase to it. Thanks. 😉

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2019
@feloy
Copy link
Member Author

feloy commented Dec 22, 2019

@shu-mutou it is now rebased to #4700

@shu-mutou
Copy link
Contributor

/hold cancel
@feloy Thanks!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2019
@shu-mutou
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cabc06c into kubernetes:master Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Updates or issues for French translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants