Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug for pod status in replicaSet #4698

Conversation

zehuaiWANG
Copy link
Contributor

@zehuaiWANG zehuaiWANG commented Dec 22, 2019

bug fix: refer to issue #4696

In addition, I don't think we need to judge all the pods under the namespace, just judge the pods selected by the label selector

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 22, 2019
@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #4698 into master will decrease coverage by 0.01%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4698      +/-   ##
==========================================
- Coverage   45.39%   45.38%   -0.02%     
==========================================
  Files         214      214              
  Lines        9976     9980       +4     
  Branches       96       96              
==========================================
  Hits         4529     4529              
- Misses       5181     5185       +4     
  Partials      266      266
Impacted Files Coverage Δ
src/app/backend/resource/replicaset/pods.go 28.94% <23.07%> (-3.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4684c75...116d559. Read the comment docs.

@zehuaiWANG zehuaiWANG force-pushed the dashboard-fixbug-pod-status-in-replicaSet branch from cc6f739 to 60e1660 Compare December 22, 2019 09:32
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2019
@floreks
Copy link
Member

floreks commented Jan 7, 2020

In addition, I don't think we need to judge all the pods under the namespace, just judge the pods selected by the label selector

ReplicaSet can't control pods across namespaces, but different namespace can have pod with the same name, so it could cause conflicts.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, zehuaiWANG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 53d5235 into kubernetes:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants