Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zh i18n #4706

Merged
merged 1 commit into from
Dec 24, 2019
Merged

update zh i18n #4706

merged 1 commit into from
Dec 24, 2019

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Dec 23, 2019

Ref: #4259

Ref: #4705

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/zh Updates or issues for Chinese translations. labels Dec 23, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2019
@hwdef
Copy link
Member Author

hwdef commented Dec 23, 2019

/assign
@shu-mutou
@maciaszczykm

@tanjunchen
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2019
@tanjunchen
Copy link
Member

/lgtm
@shu-mutou
@maciaszczykm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2019
@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #4706 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4706      +/-   ##
==========================================
- Coverage   45.39%   45.38%   -0.02%     
==========================================
  Files         214      214              
  Lines        9976     9976              
  Branches       96       96              
==========================================
- Hits         4529     4528       -1     
- Misses       5181     5182       +1     
  Partials      266      266
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49689a...d85dd65. Read the comment docs.

@shu-mutou
Copy link
Contributor

Could you resolve inconsistency between navigation items[1] and titles[2] in each view?
[1] https://github.com/kubernetes/dashboard/blob/255025ad4a7ee0468049d7dc479e6c75c5e78fcf/i18n/zh/messages.zh.xlf#L2368-L2611
[2] https://github.com/kubernetes/dashboard/blob/255025ad4a7ee0468049d7dc479e6c75c5e78fcf/i18n/zh/messages.zh.xlf#L342-L459
At least, please decide to translate or not in navigation items[1].
Also, "设置" for Daemon Sets does not seem correct. This may be "组", "集" or "集合".

@hwdef
Copy link
Member Author

hwdef commented Dec 24, 2019

@shu-mutou
Thanks for your suggestions. I will fix it in this PR,
There may be other translations that need improvement ,and English needs to be translated into Chinese. I will create a new PR to improve them.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 24, 2019
@hwdef
Copy link
Member Author

hwdef commented Dec 24, 2019

@shu-mutou
I updated this PR, and I improved it by following the word list in the #4705 .
Please review it again. THX

@shu-mutou
Copy link
Contributor

/lgtm
We don't have conclusions for translation of k8s terms, and we can improve that in future.
But I hope final approvement by @tanjunchen.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2019
@tanjunchen
Copy link
Member

Sure , we will improve this if everybody has a better idea . so now
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwdef, shu-mutou, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tanjunchen
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit dab9668 into kubernetes:master Dec 24, 2019
@hwdef hwdef deleted the update-zh branch May 26, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants