Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Japanese translation #4784

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Update Japanese translation #4784

merged 1 commit into from
Jan 20, 2020

Conversation

shu-mutou
Copy link
Contributor

Update Japanese translation file for #4625

/cc @feloy @seokho-son @hwdef @tanjunchen

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/ja Updates or issues for Japanese translations. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 15, 2020
@shu-mutou shu-mutou requested review from atoato88 and removed request for seokho-son, feloy, hwdef and tanjunchen January 15, 2020 06:31
@codecov
Copy link

codecov bot commented Jan 15, 2020 •
edited
Loading

Codecov Report

Merging #4784 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4784      +/-   ##
==========================================
- Coverage   45.43%   45.42%   -0.02%     
==========================================
  Files         214      214              
  Lines        9977     9977              
  Branches       94       94              
==========================================
- Hits         4533     4532       -1     
- Misses       5180     5181       +1     
  Partials      264      264
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2deefb1...0ab8e33. Read the comment docs.

atoato88
atoato88 reviewed Jan 20, 2020
View reviewed changes
i18n/ja/README.md Outdated Show resolved Hide resolved
@shu-mutou shu-mutou force-pushed the i18n-ja branch 2 times, most recently from e350593 to d973551 Compare January 20, 2020 04:31
atoato88
atoato88 reviewed Jan 20, 2020
View reviewed changes
Copy link
Contributor

@atoato88 atoato88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny comment about doc format.

i18n/ja/README.md Outdated
@@ -51,6 +52,9 @@ Kubernetes Dashboard の和訳を実施するにあたって、下記の配慮
* 英単語と日本語の間には半角スペースを入れます。
+ (例) ○ `これは English word です。`
+ (例) × `これはEnglish wordです。`
+ ただし、文頭、句読点の直前直後、では、半角スペースを挿入しません。
+ (例) ◯ `これは English、Chinese、French です。`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

◯ is different from ○. ○ is used at other place In this doc.
◯ : L56
○ : L50, L53, L64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. done.

@shu-mutou
Update Japanese translation
0ab8e33 
Add translations for "Horizontal Pod Autoscalers".
Also, update README for Japanese translators.
@atoato88
Copy link
Contributor

Thank you to quick fix.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3568526 into kubernetes:master Jan 20, 2020
@shu-mutou shu-mutou mentioned this pull request Jan 22, 2020
Closed
11 tasks
@shu-mutou shu-mutou deleted the i18n-ja branch February 4, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 atoato88 left review comments

Assignees

@atoato88 atoato88

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Updates or issues for Japanese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shu-mutou @atoato88 @k8s-ci-robot