Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean translation #4819

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Conversation

seokho-son
Copy link
Member

Update Korean translation file for #4625
(related issue #4259)

Please note that I referenced the Korean translation guide() by Korean localization team in Sig-docs.
I didn't translate the term "Horizontal Pod Autoscalers" according to the Korean translation guide.

Also I hope to add @gochist as an approver of contents in i18n/ko.
@gochist is an Korean localization expert and active contributor of K8s/website as well as K8s/dashboard.

/cc @shu-mutou

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. language/ko Updates or issues for Korean translations. labels Jan 23, 2020
@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #4819 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4819   +/-   ##
=======================================
  Coverage   45.42%   45.42%           
=======================================
  Files         214      214           
  Lines        9977     9977           
  Branches       94       94           
=======================================
  Hits         4532     4532           
  Misses       5181     5181           
  Partials      264      264

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 880bccc...3b11eda. Read the comment docs.

@shu-mutou
Copy link
Contributor

/lgtm
Thanks @seokho-son, and welcome @gochist.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Updates or issues for Korean translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants