Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable access denied notifications #5004

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Add option to disable access denied notifications #5004

merged 2 commits into from
Mar 19, 2020

Conversation

maciaszczykm
Copy link
Member

Closes #4941.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 12, 2020
@k8s-ci-robot k8s-ci-robot added language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Mar 12, 2020
@maciaszczykm
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2020
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #5004 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5004      +/-   ##
==========================================
- Coverage   45.41%   45.39%   -0.02%     
==========================================
  Files         214      214              
  Lines       10055    10078      +23     
  Branches       96      100       +4     
==========================================
+ Hits         4566     4575       +9     
- Misses       5222     5236      +14     
  Partials      267      267              
Impacted Files Coverage Δ
src/app/backend/settings/handler.go 33.33% <0.00%> (+2.08%) ⬆️
...p/frontend/common/services/global/notifications.ts 35.84% <25.00%> (-2.25%) ⬇️
.../frontend/common/services/global/globalsettings.ts 39.53% <50.00%> (+0.64%) ⬆️
src/app/backend/sync/secret.go 70.29% <0.00%> (-2.98%) ⬇️
.../app/frontend/common/components/graph/component.ts 62.19% <0.00%> (-1.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c461975...0cc5f51. Read the comment docs.

@maciaszczykm
Copy link
Member Author

/hold cancel

Tested locally using minikube cluster and it works as expected.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2020
@floreks
Copy link
Member

floreks commented Mar 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2020
@floreks
Copy link
Member

floreks commented Mar 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit db3f8bf into kubernetes:master Mar 19, 2020
@feloy feloy mentioned this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable auth error notifications
3 participants