-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update service list to show correct "success" status for "ExternalName" #5010
update service list to show correct "success" status for "ExternalName" #5010
Conversation
…e is "ExternalName"; patch for kubernetes#4736 Signed-off-by: mystic knight <techguru@byiq.com>
Welcome @PaulCharlton! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PaulCharlton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: mystic knight <techguru@byiq.com>
Codecov Report
@@ Coverage Diff @@
## master #5010 +/- ##
=======================================
Coverage 45.42% 45.42%
=======================================
Files 214 214
Lines 10066 10066
Branches 98 98
=======================================
Hits 4572 4572
Misses 5226 5226
Partials 268 268
Continue to review full report at Codecov.
|
/assign @mhenc |
… instead of nested if for longer term resilience Signed-off-by: mystic knight <techguru@byiq.com>
Signed-off-by: mystic knight <techguru@byiq.com>
Signed-off-by: mystic knight <techguru@byiq.com>
update service list to show correct "success" status for "ExternalName"; patch for #4736
Signed-off-by: mystic knight techguru@byiq.com