Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update service list to show correct "success" status for "ExternalName" #5010

Conversation

PaulCharlton
Copy link
Contributor

@PaulCharlton PaulCharlton commented Mar 15, 2020

update service list to show correct "success" status for "ExternalName"; patch for #4736

Signed-off-by: mystic knight techguru@byiq.com

…e is "ExternalName"; patch for kubernetes#4736

Signed-off-by: mystic knight <techguru@byiq.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @PaulCharlton!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PaulCharlton
To complete the pull request process, please assign mhenc
You can assign the PR to them by writing /assign @mhenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: mystic knight <techguru@byiq.com>
@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #5010 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5010   +/-   ##
=======================================
  Coverage   45.42%   45.42%           
=======================================
  Files         214      214           
  Lines       10066    10066           
  Branches       98       98           
=======================================
  Hits         4572     4572           
  Misses       5226     5226           
  Partials      268      268           
Impacted Files Coverage Δ
src/app/backend/resource/service/list.go 93.75% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae3d469...457351a. Read the comment docs.

@PaulCharlton
Copy link
Contributor Author

/assign @mhenc

… instead of nested if for longer term resilience

Signed-off-by: mystic knight <techguru@byiq.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2020
Signed-off-by: mystic knight <techguru@byiq.com>
Signed-off-by: mystic knight <techguru@byiq.com>
@maciaszczykm maciaszczykm merged commit 7188d81 into kubernetes:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants