Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update service list to show correct "success" status for "ExternalName" #5010

Merged
merged 5 commits into from
Mar 16, 2020
Merged

update service list to show correct "success" status for "ExternalName" #5010

merged 5 commits into from
Mar 16, 2020

Commits on Mar 15, 2020

  1. update service list to show correct "success" status when service typ… 

    …e is "ExternalName"; patch for kubernetes#4736

Signed-off-by: mystic knight <techguru@byiq.com>
    @PaulCharlton
    PaulCharlton committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    e2b930f View commit details
    Browse the repository at this point in the history

  2. reformat code per guidance from CI style checks 

    Signed-off-by: mystic knight <techguru@byiq.com>
    @PaulCharlton
    PaulCharlton committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    8106820 View commit details
    Browse the repository at this point in the history

  3. reformat code per guidance from CI style checks; use switch statement… 

    … instead of nested if for longer term resilience

Signed-off-by: mystic knight <techguru@byiq.com>
    @PaulCharlton
    PaulCharlton committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    8fa2b93 View commit details
    Browse the repository at this point in the history

  4. eliminate fall-through per style guidance from CI 

    Signed-off-by: mystic knight <techguru@byiq.com>
    @PaulCharlton
    PaulCharlton committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    e2c5c9e View commit details
    Browse the repository at this point in the history

  5. eliminate parenthesis per style guidance from CI 

    Signed-off-by: mystic knight <techguru@byiq.com>
    @PaulCharlton
    PaulCharlton committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    457351a View commit details
    Browse the repository at this point in the history