Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deply redirect and error messages #5033

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Fix deply redirect and error messages #5033

merged 1 commit into from
Mar 26, 2020

Conversation

maciaszczykm
Copy link
Member

Solves the issue mentioned in #4328 (comment).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@floreks
Copy link
Member

floreks commented Mar 26, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #5033 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5033      +/-   ##
==========================================
+ Coverage   45.41%   45.42%   +0.01%     
==========================================
  Files         214      214              
  Lines       10055    10078      +23     
  Branches       96      100       +4     
==========================================
+ Hits         4566     4578      +12     
- Misses       5222     5232      +10     
- Partials      267      268       +1
Impacted Files Coverage Δ
src/app/frontend/common/errors/errors.ts 53.84% <ø> (ø) ⬆️
...p/frontend/common/services/global/notifications.ts 35.84% <0%> (-2.25%) ⬇️
.../app/frontend/common/components/graph/component.ts 62.19% <0%> (-1.19%) ⬇️
.../frontend/common/services/global/globalsettings.ts 39.53% <0%> (+0.64%) ⬆️
src/app/backend/settings/handler.go 33.33% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c461975...9b20a8a. Read the comment docs.

@floreks
Copy link
Member

floreks commented Mar 26, 2020

Fixes #4282

@floreks floreks linked an issue Mar 26, 2020 that may be closed by this pull request
@k8s-ci-robot k8s-ci-robot merged commit 1a14d69 into kubernetes:master Mar 26, 2020
@maciaszczykm maciaszczykm deleted the fix/deploy-fixes branch March 27, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard does not remember namespace after adding resource.
3 participants