Add namspace parameter for CreateContent redirect to overview

[anshulahuja98]

Fixes #4282

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anshulahuja98
To complete the pull request process, please assign mhenc
You can assign the PR to them by writing /assign @mhenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #4328 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4328      +/-   ##
==========================================
- Coverage   46.62%   46.61%   -0.02%     
==========================================
  Files         200      200              
  Lines        9373     9373              
  Branches      105      105              
==========================================
- Hits         4370     4369       -1     
- Misses       4734     4735       +1     
  Partials      269      269

Impacted Files	Coverage Δ
...p/backend/integration/metric/common/aggregation.go	89.09% <0%> (-1.82%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1b8c6...7680a79. Read the comment docs.

[floreks]

Using spec.namespace will make it follow the namespace of the created resource. I am not sure if we should switch to the namespace of created resource or simply stick with the current namespace.

@maciaszczykm WDYT?

[maciaszczykm]

Not sure too, perhaps we can add dialog if the user wants his ns to be switched?

[anshulahuja98]

This approach is followed in deploy() method which is used in create from form

dashboard/src/app/frontend/common/services/create/service.ts

Line 128 in 7680a79

this.router_.navigate(['overview'], {

[anshulahuja98]

@floreks , the namespace assigned in the spec for createContent() is anyways the current namespace. I didn't realize to point it out earlier.

This is also because in create from input, there isn't an option to explicitly mention the ns. It's current by default

dashboard/src/app/frontend/common/services/create/service.ts

Line 71 in 7680a79

namespace: this.namespace_.current(),

[floreks]

@anshulahuja98 If you choose create from input/file then it's very easy to override the namespace via the resource definition.

apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    k8s-app: kubernetes-dashboard
  name: kubernetes-dashboard
  namespace: xyz

Then the namespace from the file will be taken to create a new resource. That's why changing the namespace to the namespace of the resource might not be a good idea. It's sometimes hidden from the user eyes and possibly not really expected.

[feloy]

Note that when trying to create a resource specifying another namespace from the actual namespace, you will get an error "Deploying file has failed: MSG_DEPLOY_NAMESPACE_MISMATCH_ERROR"

So in case of success, the current namespace and the namespace of the created resource will be the same one

[zehuaiWANG]

Yes, I think it might be more appropriate to keep the current namespace. If the user fails to create resource from yaml, switching to the namespace in yaml will cause bad results. It's also not good to get different solutions in different kind of cases, which will make users confused.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[maciaszczykm]

I've investigated this, checked the previous version and the current implementation is correct. We have 3 ways of deploying something from the app:

• deploy from file
• deploy from input
• deploy from settings (using the form)

In first two cases we would like to avoid switching to the namespace of the new thing that was deployed as it may be unexpected. We don't want to confuse users here.

The only case that we think should redirect to the new namespace was when the user was using the form in the create wizard and picked the different namespace on his own.

See the implementation from last version before v2: https://github.com/kubernetes/dashboard/blob/v1.10.1/src/app/frontend/deploy/service.js#L142

Moreover, it is not possible to create from input to the namespace different than currently selected:

The only problem right now seems to be that if we create from input resource in the namespace X we end up in the default namespace. I will fix that.