Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update zh-hans translation #5179

Merged
merged 1 commit into from
May 26, 2020
Merged

update zh-hans translation #5179

merged 1 commit into from
May 26, 2020

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented May 26, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 26, 2020
@k8s-ci-robot k8s-ci-robot added the language/zh Updates or issues for Chinese translations. label May 26, 2020
@hwdef
Copy link
Member Author

hwdef commented May 26, 2020 •
edited
Loading

/assign
@tanjunchen
@chenrui333

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020 •
edited
Loading

Codecov Report

Merging #5179 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5179   +/-   ##
=======================================
  Coverage   45.47%   45.47%           
=======================================
  Files         214      214           
  Lines       10094    10094           
  Branches      107      107           
=======================================
  Hits         4590     4590           
  Misses       5238     5238           
  Partials      266      266

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70af88c...b624b25. Read the comment docs.

zehuaiWANG
zehuaiWANG reviewed May 26, 2020
View reviewed changes
i18n/zh-Hans/messages.zh-Hans.xlf
<target state="new">
Insecure access detected. Sign in will not be available. Access Dashboard securely over HTTPS or using localhost. Read more
<target>
检测到不安全的访问。无法登陆。通过 HTTPS 或使用 localhost 安全访问 Dashboard 。更多信息
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的localhost翻译成本地是否更好？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我借鉴了日文的翻译方式，localhost在这里可能特指 dashboard 运行的节点。
#5174

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. 其他的应该没什么问题。

@hwdef hwdef closed this May 26, 2020
@hwdef hwdef deleted the update-zh-trans2 branch May 26, 2020 05:56
@hwdef hwdef restored the update-zh-trans2 branch May 26, 2020 05:56
@hwdef hwdef reopened this May 26, 2020
@zehuaiWANG
Copy link
Contributor

/lgtm Thank you for your contribution! @hwdef

@tanjunchen
Copy link
Member

/LGTM
@hwdef Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwdef, tanjunchen, zehuaiWANG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fbd43c3 into kubernetes:master May 26, 2020
@hwdef hwdef deleted the update-zh-trans2 branch May 29, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zehuaiWANG zehuaiWANG zehuaiWANG left review comments

@chenrui333 chenrui333 Awaiting requested review from chenrui333

Assignees

@hwdef hwdef

@tanjunchen tanjunchen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hwdef @zehuaiWANG @tanjunchen @k8s-ci-robot