Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable graph refresh when it is not visible #5198

Merged
merged 1 commit into from
May 28, 2020

Conversation

floreks
Copy link
Member

@floreks floreks commented May 28, 2020

Fixes #5099

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 28, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #5198 into master will increase coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5198      +/-   ##
==========================================
+ Coverage   45.43%   45.46%   +0.03%     
==========================================
  Files         214      214              
  Lines       10094    10099       +5     
  Branches      107      108       +1     
==========================================
+ Hits         4586     4592       +6     
+ Misses       5243     5240       -3     
- Partials      265      267       +2     
Impacted Files Coverage Δ
.../app/frontend/common/components/graph/component.ts 60.46% <50.00%> (-1.74%) ⬇️
src/app/frontend/shared.module.ts 100.00% <100.00%> (ø)
...p/backend/integration/metric/common/aggregation.go 90.90% <0.00%> (+1.81%) ⬆️
src/app/backend/sync/secret.go 73.26% <0.00%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 146356d...c1aea2c. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 56c79bc into kubernetes:master May 28, 2020
@floreks floreks deleted the fix/autoscroll branch May 28, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Refresh scrolls the page to top
3 participants