go mod: mark as v2

[bengadbois]

For go module versions >1, the version should be marked

See https://github.com/google/go-github/blob/master/go.mod as an example

[k8s-ci-robot]

Welcome @bengadbois!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bengadbois
To complete the pull request process, please assign cheld
You can assign the PR to them by writing /assign @cheld in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bengadbois]

/assign @cheld

[floreks]

I am not really a fan of this solution. We do use go modules but Dashboard is not really intended to be used as a dependency and was never designed to follow go standards for creating modules.

[maciaszczykm]

I remember there was similar issue in the past and we had some issues with changing all versions to v2. I agree with @floreks that our focus is not to provide backend that can be reused, we focus to make it work for our app. However, if you make it work and it will not be hacky I think we can merge since it will not harm us.

[floreks]

Related to #5086

[floreks]

We might rethink that while designing a new API and splitting UI/API into different containers.

/close

[k8s-ci-robot]

@bengadbois: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@floreks: Closed this PR.

In response to this:

We might rethink that while designing a new API and splitting UI/API into different containers.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.