Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add france for language selector #5696

Merged
merged 1 commit into from
Nov 30, 2020
Merged

add france for language selector #5696

merged 1 commit into from
Nov 30, 2020

Conversation

helight
Copy link
Contributor

@helight helight commented Nov 27, 2020

const SUPPORTED_LANGUAGES: LanguageConfig[] = [
{
label: 'German',
value: 'de',
},
{
label: 'French',
value: 'fr',
},
....

image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2020
@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #5696 (6b5a4c1) into master (5264516) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5696      +/-   ##
==========================================
- Coverage   44.36%   44.35%   -0.02%     
==========================================
  Files         214      214              
  Lines        9124     9124              
  Branches      113      113              
==========================================
- Hits         4048     4047       -1     
- Misses       4801     4802       +1     
  Partials      275      275              
Impacted Files Coverage Δ
src/app/frontend/index.config.ts 100.00% <ø> (ø)
...p/backend/integration/metric/common/aggregation.go 88.00% <0.00%> (-2.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5264516...6b5a4c1. Read the comment docs.

@maciaszczykm
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: helight, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
@maciaszczykm maciaszczykm merged commit 5cb109f into kubernetes:master Nov 30, 2020
@helight helight deleted the add_france_for_language_select branch November 30, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants