Implements rollout APIs for deployment #5917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/ko
shu-mutou
requested review from
maciaszczykm and
floreks
and removed request for
helight and
chenrui333
Closed
Codecov Report
@@ Coverage Diff @@
## master #5917 +/- ##
==========================================
- Coverage 42.40% 41.98% -0.42%
==========================================
Files 215 216 +1
Lines 9195 9325 +130
Branches 155 155
==========================================
+ Hits 3899 3915 +16
- Misses 5044 5158 +114
Partials 252 252 |
floreks
requested changes
Mar 25, 2021
k8s-ci-robot
added
the
needs-rebase
|
@floreks Thanks for reviewing! I'll update this PR next week. |
k8s-ci-robot
added
size/XL
floreks
reviewed
Apr 1, 2021
|
This is a very useful functionality. Just a last small comment and we can merge. |
This implements REST APIs for `kubectl rollout deployment` command. Also, implements frontend for `kubectl rollout restart deployment` command. Co-authored-by: ZeHuaiWang <874697675@qq.com>
Also, refactor followings: - Change http method for rollout actions to PUT, following other actions. - Define annotation keys as const.
k8s-ci-robot
added
size/XXL
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements REST APIs for
kubectl rollout deploymentcommand.Also, implements frontend for
kubectl rollout restart deploymentcommand.Co-authored-by: ZeHuaiWang 874697675@qq.com
Ref: #2889, #4542
Fixes: #4254