-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove token check and add user info #6800
Conversation
c5f56aa
to
4ccbb3c
Compare
Codecov Report
@@ Coverage Diff @@
## master #6800 +/- ##
==========================================
- Coverage 41.82% 41.49% -0.34%
==========================================
Files 44 44
Lines 1241 1234 -7
Branches 164 162 -2
==========================================
- Hits 519 512 -7
Misses 722 722 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ility Amazon EKS supportted version have major changes over years - https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html#kubernetes-release-calendar but the version for Kubernetes Dashboard have not been update for years, last update was made on Dec 10, 2020. ---- commit fc59dad Date: Thu, 10 Dec 2020 04:42:44 +0800 ---- should consider to upgrade its version shown on documentation to ensure its compatibility. Furthermore, eksworkshop is now pointing to v2.0.0, should upgrade as well. - https://www.eksworkshop.com/beginner/040_dashboard/dashboard/ Additionally, v2.5.0 having the following bugs that we should avoid it. - kubernetes/dashboard#6784 - kubernetes/dashboard#6784 (comment) - kubernetes/dashboard#6800
…ility Amazon EKS supportted version have major changes over years - https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html#kubernetes-release-calendar but the version for Kubernetes Dashboard have not been update for years, last update was made on Dec 10, 2020. ---- commit fc59dad Date: Thu, 10 Dec 2020 04:42:44 +0800 ---- should consider to upgrade its version shown on documentation to ensure its compatibility. Furthermore, eksworkshop is now pointing to v2.0.0, should be upgraded as well. - https://www.eksworkshop.com/beginner/040_dashboard/dashboard/ Additionally, v2.5.0 having the following bugs that we should avoid it. - kubernetes/dashboard#6784 - kubernetes/dashboard#6784 (comment) - kubernetes/dashboard#6800
…ility Amazon EKS supportted version have major changes over years - https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html#kubernetes-release-calendar but the version for Kubernetes Dashboard have not been update for years, last update was made on Jul 9, 2020. ---- commit 822d941 Date: Thu, 9 Jul 2020 11:47:59 +0800 ---- should consider to upgrade its version shown on documentation to ensure its compatibility. Furthermore, eksworkshop is now pointing to v2.0.0, should be upgraded as well. - https://www.eksworkshop.com/beginner/040_dashboard/dashboard/ Additionally, v2.5.0 having the following bugs that we should avoid it. - kubernetes/dashboard#6784 - kubernetes/dashboard#6784 (comment) - kubernetes/dashboard#6800
…ility (#1477) Amazon EKS supportted version have major changes over years - https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html#kubernetes-release-calendar but the version for Kubernetes Dashboard have not been update for years, last update was made on Jul 9, 2020. ---- commit 822d941 Date: Thu, 9 Jul 2020 11:47:59 +0800 ---- should consider to upgrade its version shown on documentation to ensure its compatibility. Furthermore, eksworkshop is now pointing to v2.0.0, should be upgraded as well. - https://www.eksworkshop.com/beginner/040_dashboard/dashboard/ Additionally, v2.5.0 having the following bugs that we should avoid it. - kubernetes/dashboard#6784 - kubernetes/dashboard#6784 (comment) - kubernetes/dashboard#6800 Co-authored-by: Mathieu Bruneau <ROunofF@users.noreply.github.com>
Fixes #6784
When available user name will be shown in the user panel, otherwise old "logged in with xxx" messages will be shown. We can potentially use this information in the future for other things.
![image](https://user-images.githubusercontent.com/2285385/153416260-61859114-a194-4d02-a13f-41d3f5b5042f.png)