Remove token check and add user info #6800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/fr
floreks
force-pushed
the
fix/login-token
branch
from
c5f56aa
to
4ccbb3c
Compare
Codecov Report
@@ Coverage Diff @@
## master #6800 +/- ##
==========================================
- Coverage 41.82% 41.49% -0.34%
==========================================
Files 44 44
Lines 1241 1234 -7
Branches 164 162 -2
==========================================
- Hits 519 512 -7
Misses 722 722 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
guessi
added a commit
to guessi/amazon-eks-user-guide
that referenced
this pull request
Jul 22, 2022
…ility Amazon EKS supportted version have major changes over years - https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html#kubernetes-release-calendar but the version for Kubernetes Dashboard have not been update for years, last update was made on Dec 10, 2020. ---- commit fc59dad Date: Thu, 10 Dec 2020 04:42:44 +0800 ---- should consider to upgrade its version shown on documentation to ensure its compatibility. Furthermore, eksworkshop is now pointing to v2.0.0, should upgrade as well. - https://www.eksworkshop.com/beginner/040_dashboard/dashboard/ Additionally, v2.5.0 having the following bugs that we should avoid it. - kubernetes/dashboard#6784 - kubernetes/dashboard#6784 (comment) - kubernetes/dashboard#6800
guessi
added a commit
to guessi/amazon-eks-user-guide
that referenced
this pull request
Jul 22, 2022
…ility Amazon EKS supportted version have major changes over years - https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html#kubernetes-release-calendar but the version for Kubernetes Dashboard have not been update for years, last update was made on Dec 10, 2020. ---- commit fc59dad Date: Thu, 10 Dec 2020 04:42:44 +0800 ---- should consider to upgrade its version shown on documentation to ensure its compatibility. Furthermore, eksworkshop is now pointing to v2.0.0, should be upgraded as well. - https://www.eksworkshop.com/beginner/040_dashboard/dashboard/ Additionally, v2.5.0 having the following bugs that we should avoid it. - kubernetes/dashboard#6784 - kubernetes/dashboard#6784 (comment) - kubernetes/dashboard#6800
guessi
added a commit
to guessi/eks-workshop
that referenced
this pull request
Jul 22, 2022
…ility Amazon EKS supportted version have major changes over years - https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html#kubernetes-release-calendar but the version for Kubernetes Dashboard have not been update for years, last update was made on Jul 9, 2020. ---- commit 822d941 Date: Thu, 9 Jul 2020 11:47:59 +0800 ---- should consider to upgrade its version shown on documentation to ensure its compatibility. Furthermore, eksworkshop is now pointing to v2.0.0, should be upgraded as well. - https://www.eksworkshop.com/beginner/040_dashboard/dashboard/ Additionally, v2.5.0 having the following bugs that we should avoid it. - kubernetes/dashboard#6784 - kubernetes/dashboard#6784 (comment) - kubernetes/dashboard#6800
ROunofF
added a commit
to aws-samples/eks-workshop
that referenced
this pull request
Sep 30, 2022
…ility (#1477) Amazon EKS supportted version have major changes over years - https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html#kubernetes-release-calendar but the version for Kubernetes Dashboard have not been update for years, last update was made on Jul 9, 2020. ---- commit 822d941 Date: Thu, 9 Jul 2020 11:47:59 +0800 ---- should consider to upgrade its version shown on documentation to ensure its compatibility. Furthermore, eksworkshop is now pointing to v2.0.0, should be upgraded as well. - https://www.eksworkshop.com/beginner/040_dashboard/dashboard/ Additionally, v2.5.0 having the following bugs that we should avoid it. - kubernetes/dashboard#6784 - kubernetes/dashboard#6784 (comment) - kubernetes/dashboard#6800 Co-authored-by: Mathieu Bruneau <ROunofF@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6784
When available user name will be shown in the user panel, otherwise old "logged in with xxx" messages will be shown. We can potentially use this information in the future for other things.
