Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move about page to footer #7490

Merged
merged 7 commits into from
Oct 7, 2022
Merged

Move about page to footer #7490

merged 7 commits into from
Oct 7, 2022

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Sep 30, 2022 •
edited
Loading

Zrzut ekranu 2022-10-7 o 12 56 36

Zrzut ekranu 2022-10-7 o 12 56 25

Closes #7141.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. language/de Updates or issues for German translations. labels Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added language/fr Updates or issues for French translations. approved Indicates a PR has been approved by an approver from all required OWNERS files. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Sep 30, 2022
@codecov
Copy link

codecov bot commented Sep 30, 2022 •
edited
Loading

Codecov Report

Merging #7490 (09dbb6e) into master (16cefa8) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7490      +/-   ##
==========================================
- Coverage   42.20%   42.10%   -0.10%     
==========================================
  Files         220      217       -3     
  Lines       12111    12084      -27     
  Branches      179      179              
==========================================
- Hits         5111     5088      -23     
+ Misses       6716     6711       -5     
- Partials      284      285       +1

@maciaszczykm maciaszczykm marked this pull request as ready for review October 7, 2022 10:57
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2022
floreks
floreks approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@floreks floreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cce750e into kubernetes:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks floreks approved these changes

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@helight helight Awaiting requested review from helight

Assignees

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move about page to footer
3 participants
@maciaszczykm @k8s-ci-robot @floreks