-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to skip iptables rules setup in nodecache #302
Conversation
This can be used if iptabls management is being offloaded to a different daemonset. that manages iptables and other networking setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, prameshj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This has been left as an implementer's choice right now - to identify which existing daemonset to pack this functionality into. The logic will be along the lines of: state = "enabled" sleep time and the threshold count can be customized. This container would also manage setup of all iptables rules fornode-cache. Are you looking for an image that can be run as a new daemonset? |
@prameshj Thank you for your reply |
This can be used if iptables management is being offloaded to a different daemonset.
that manages iptables and other networking setup. HA using the approach described here becomes easier with this. All the iptables and liveness check logic resides in this other daemonset.