Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to skip iptables rules setup in nodecache #302

Merged
merged 1 commit into from
May 28, 2019

Conversation

prameshj
Copy link
Contributor

This can be used if iptables management is being offloaded to a different daemonset.
that manages iptables and other networking setup. HA using the approach described here becomes easier with this. All the iptables and liveness check logic resides in this other daemonset.

This can be used if iptabls management is being offloaded to a different daemonset.
that manages iptables and other networking setup.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 28, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and MrHohn May 28, 2019 06:52
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2019
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, prameshj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit db130f0 into kubernetes:master May 28, 2019
@carterzhao
Copy link

@prameshj Another daemonset component is needed to dynamically determine when to use node-local-dns and when to flip to kube-dns endpoints here. I just can't find the code of the watcher component.

@prameshj
Copy link
Contributor Author

@prameshj Another daemonset component is needed to dynamically determine when to use node-local-dns and when to flip to kube-dns endpoints here. I just can't find the code of the watcher component.

This has been left as an implementer's choice right now - to identify which existing daemonset to pack this functionality into. The logic will be along the lines of:

state = "enabled"
for {
measure time taken for "dig @169.254.20.10 kubernetes.default.svc.cluster.local"
if query times out 'n' consecutive times, remove NOTRACK iptables rules and set state to 'disabled'.
if query successful 'n' successful times and current state is 'disabled', add the rules back.
sleep 2s
}

sleep time and the threshold count can be customized. This container would also manage setup of all iptables rules fornode-cache.

Are you looking for an image that can be run as a new daemonset?

@carterzhao
Copy link

@prameshj Thank you for your reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants