Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate NodeLocal DNSCache to GA #1024

Closed
prameshj opened this issue Apr 30, 2019 · 57 comments
Closed

Graduate NodeLocal DNSCache to GA #1024

prameshj opened this issue Apr 30, 2019 · 57 comments
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@prameshj
Copy link
Contributor

prameshj commented Apr 30, 2019

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 30, 2019
@prameshj
Copy link
Contributor Author

prameshj commented Apr 30, 2019

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 30, 2019
@prameshj
Copy link
Contributor Author

prameshj commented Apr 30, 2019

/assign prameshj

@prameshj
Copy link
Contributor Author

prameshj commented Apr 30, 2019

/milestone v1.15
/stage beta

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 30, 2019

@prameshj: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.15
/stage beta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Apr 30, 2019
@kacole2 kacole2 added this to the v1.15 milestone Apr 30, 2019
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 30, 2019
@makoscafee
Copy link
Member

makoscafee commented May 10, 2019

Hey, @prameshj 👋 I'm the v1.15 docs Lead.
Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@prameshj
Copy link
Contributor Author

prameshj commented May 10, 2019

Thanks, @makoscafee , I will open a PR and update the docs. Most of the code changes for this will be in the kubernetes/dns repo. I will update the docs and the image version in k/k. I'll open a placeholder PR in a day.

@prameshj
Copy link
Contributor Author

prameshj commented May 14, 2019

Pleaceholder PR : kubernetes/kubernetes#77887

@makoscafee
Copy link
Member

makoscafee commented May 15, 2019

Hi @prameshj above is not docs placeholder PR, right?

@kacole2
Copy link
Member

kacole2 commented May 28, 2019

Hi @prameshj . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@prameshj
Copy link
Contributor Author

prameshj commented May 28, 2019

Thanks for the reminder, @kacole2

We need the following PRs merged:
kubernetes/kubernetes#78417
kubernetes/kubernetes#77887
Also, kubernetes/dns#302 and the new image to be used in the k/k yaml. I am planning to complete these by the code freeze deadline.

@makoscafee
Copy link
Member

makoscafee commented May 29, 2019

Hi @prameshj sorry! will this enhancement need user documentation in k/website apart from k/dns ? if yes can you open Placeholder PR before 30th which is the deadline for that. Thanks

@prameshj
Copy link
Contributor Author

prameshj commented May 30, 2019

Hi @prameshj sorry! will this enhancement need user documentation in k/website apart from k/dns ? if yes can you open Placeholder PR before 30th which is the deadline for that. Thanks

created kubernetes/website#14625

@prameshj
Copy link
Contributor Author

prameshj commented May 31, 2019

Forgot to mention, this PR needs to be in the 1.15 milestone as well.
kubernetes/kubernetes#78546

@kacole2
Copy link
Member

kacole2 commented Jul 8, 2019

Hi @prameshj , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 9, 2019
@kacole2 kacole2 removed this from the v1.15 milestone Jul 9, 2019
@prameshj
Copy link
Contributor Author

prameshj commented Aug 14, 2019

Sorry for the delayed response, we are not graduating to stable in 1.16. Will try to target the next release.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Oct 1, 2019

Hey there @prameshj -- 1.17 Enhancements shadow here 👋 . I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!!

@prameshj
Copy link
Contributor Author

prameshj commented Oct 1, 2019

Hi @jeremyrickard , This has already graduated to beta in 1.15. We will target Stable in 1.18.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Oct 1, 2019

@prameshj oops I removed the wrong stages when I was dropping the template in here! Thanks, I'll have this marked for 1.18!

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Oct 1, 2019

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Oct 1, 2019
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Mar 6, 2020

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone Mar 6, 2020
@jeremyrickard jeremyrickard added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Mar 6, 2020
@prameshj
Copy link
Contributor Author

prameshj commented Mar 6, 2020

@jeremyrickard Thanks for pointing this out - the PR kubernetes/kubernetes#88877 is ready to merge and I just added the milestone.
It is just changing the image version. I do not need an extension for making any more code changes, they are already made. Is the exception request in order to allow this PR to be merged?

@prameshj
Copy link
Contributor Author

prameshj commented Mar 6, 2020

@jeremyrickard Just in case this is still needed, can you check if the request looks ok? I will send an email with this once i hear from you.
Enhancement name: NodeLocal DNSCache
Enhancement status (alpha/beta/stable): stable
SIG: Network
k/enhancements repo issue #: 1024
PR #’s: kubernetes/kubernetes#88877
Additional time needed (in days): 1
Reason this enhancement is critical for this milestone: This is a very important feature that improves DNS latency in kubernetes clusters.
Risks from adding code late: None
Risks from cutting enhancement: The feature went beta 3 releases ago in 1.15, missing this release for stable will make the graduation time much longer and create friction in usage of the feature.

@prameshj
Copy link
Contributor Author

prameshj commented Mar 6, 2020

Also, the latest node-cache image can be used in any cluster and it has all the features we wanted for GA. The PR - kubernetes/kubernetes#88877 changes the version just for scripts using GCE, so it is not critical to make this change for graduating to GA.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Mar 6, 2020

@prameshj yeah, please submit the exception request. What you showed as the example above looks good.

@prameshj
Copy link
Contributor Author

prameshj commented Mar 6, 2020

Thanks @jeremyrickard , i just sent the email.

@prameshj
Copy link
Contributor Author

prameshj commented Mar 6, 2020

@jeremyrickard Could you mark this enhancement as tracked for 1.18? Thanks!

@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Mar 6, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Mar 6, 2020

/milestone 1.18

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 6, 2020

@kikisdeliveryservice: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Mar 6, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 6, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 9, 2020

@prameshj Since, this enhancement graduated to Stable in 1.18, can you please mark it as implemented?

@prameshj
Copy link
Contributor Author

prameshj commented Apr 9, 2020

This is already marked as implemented - https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/0030-nodelocal-dns-cache.md
Is that what you were referring to?

@palnabarun
Copy link
Member

palnabarun commented Apr 16, 2020

@prameshj The KEP in the issue comment. I am guessing there were different KEPs for beta and stable.

Can you please also mark this KEP implemented? 🙂

@prameshj
Copy link
Contributor Author

prameshj commented Apr 16, 2020

Done - #1695

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 27, 2020
@fejta-bot
Copy link

fejta-bot commented Jul 26, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2020
@palnabarun
Copy link
Member

palnabarun commented Jul 28, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 29, 2020

This Issue has an outstanding PR: #2006 That needs approval to mark it as implemented so we can close it. Can someone PTAL?

@kikisdeliveryservice kikisdeliveryservice removed this from the v1.18 milestone Oct 30, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 30, 2020

Since #2006 has merged, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests