Graduate NodeLocal DNSCache to GA

[prameshj]

Enhancement Description

• One-line enhancement description (can be used as a release note):
  Graduate NodeLocal DNSCache to beta

• Kubernetes Enhancement Proposal: 20190424-NodeLocalDNS-beta-proposal.md

  • PR to update the KEP: GA graduation criteria for NodeLocal DNSCache #1351

• Primary contact (assignee): @prameshj

• Responsible SIGs: sig-network

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y) 1.13
  • Beta release target (x.y) 1.15
  • Stable release target (x.y) 1.18

[prameshj]

/sig network

[prameshj]

/assign prameshj

[prameshj]

/milestone v1.15
/stage beta

[k8s-ci-robot]

@prameshj: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.15
/stage beta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[makoscafee]

Hey, @prameshj 👋 I'm the v1.15 docs Lead.
Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[prameshj]

Thanks, @makoscafee , I will open a PR and update the docs. Most of the code changes for this will be in the kubernetes/dns repo. I will update the docs and the image version in k/k. I'll open a placeholder PR in a day.

[prameshj]

Pleaceholder PR : kubernetes/kubernetes#77887

[makoscafee]

Hi @prameshj above is not docs placeholder PR, right?

[kacole2]

Hi @prameshj . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

[prameshj]

Thanks for the reminder, @kacole2

We need the following PRs merged:
kubernetes/kubernetes#78417
kubernetes/kubernetes#77887
Also, kubernetes/dns#302 and the new image to be used in the k/k yaml. I am planning to complete these by the code freeze deadline.

[makoscafee]

Hi @prameshj sorry! will this enhancement need user documentation in k/website apart from k/dns ? if yes can you open Placeholder PR before 30th which is the deadline for that. Thanks

[prameshj]

Hi @prameshj sorry! will this enhancement need user documentation in k/website apart from k/dns ? if yes can you open Placeholder PR before 30th which is the deadline for that. Thanks

created kubernetes/website#14625

[prameshj]

Forgot to mention, this PR needs to be in the 1.15 milestone as well.
kubernetes/kubernetes#78546

[kacole2]

Hi @prameshj , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[prameshj]

Sorry for the delayed response, we are not graduating to stable in 1.16. Will try to target the next release.

[jeremyrickard]

Hey there @prameshj -- 1.17 Enhancements shadow here 👋 . I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!!

[prameshj]

Hi @jeremyrickard , This has already graduated to beta in 1.15. We will target Stable in 1.18.

[jeremyrickard]

@prameshj oops I removed the wrong stages when I was dropping the template in here! Thanks, I'll have this marked for 1.18!

[jeremyrickard]

/milestone v1.18

[jeremyrickard]

/milestone clear

[prameshj]

@jeremyrickard Thanks for pointing this out - the PR kubernetes/kubernetes#88877 is ready to merge and I just added the milestone.
It is just changing the image version. I do not need an extension for making any more code changes, they are already made. Is the exception request in order to allow this PR to be merged?

[prameshj]

@jeremyrickard Just in case this is still needed, can you check if the request looks ok? I will send an email with this once i hear from you.
Enhancement name: NodeLocal DNSCache
Enhancement status (alpha/beta/stable): stable
SIG: Network
k/enhancements repo issue #: 1024
PR #’s: kubernetes/kubernetes#88877
Additional time needed (in days): 1
Reason this enhancement is critical for this milestone: This is a very important feature that improves DNS latency in kubernetes clusters.
Risks from adding code late: None
Risks from cutting enhancement: The feature went beta 3 releases ago in 1.15, missing this release for stable will make the graduation time much longer and create friction in usage of the feature.

[prameshj]

Also, the latest node-cache image can be used in any cluster and it has all the features we wanted for GA. The PR - kubernetes/kubernetes#88877 changes the version just for scripts using GCE, so it is not critical to make this change for graduating to GA.

[jeremyrickard]

@prameshj yeah, please submit the exception request. What you showed as the example above looks good.

[prameshj]

Thanks @jeremyrickard , i just sent the email.

[prameshj]

@jeremyrickard Could you mark this enhancement as tracked for 1.18? Thanks!

[kikisdeliveryservice]

/milestone 1.18

[k8s-ci-robot]

@kikisdeliveryservice: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeremyrickard]

/milestone v1.18

[palnabarun]

@prameshj Since, this enhancement graduated to Stable in 1.18, can you please mark it as implemented?

[prameshj]

This is already marked as implemented - https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/0030-nodelocal-dns-cache.md
Is that what you were referring to?

[palnabarun]

@prameshj The KEP in the issue comment. I am guessing there were different KEPs for beta and stable.

Can you please also mark this KEP implemented? 🙂

[prameshj]

Done - #1695

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[kikisdeliveryservice]

This Issue has an outstanding PR: #2006 That needs approval to mark it as implemented so we can close it. Can someone PTAL?

[kikisdeliveryservice]

Since #2006 has merged, closing this issue.