Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate NodeLocal DNSCache to GA #1024

Open
prameshj opened this issue Apr 30, 2019 · 49 comments
Open

Graduate NodeLocal DNSCache to GA #1024

prameshj opened this issue Apr 30, 2019 · 49 comments
Assignees
Milestone

Comments

@prameshj
Copy link
Contributor

@prameshj prameshj commented Apr 30, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note):
    Graduate NodeLocal DNSCache to beta

  • Kubernetes Enhancement Proposal: 20190424-NodeLocalDNS-beta-proposal.md

    • PR to update the KEP: #1351
  • Primary contact (assignee): @prameshj

  • Responsible SIGs: sig-network

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y) 1.13
    • Beta release target (x.y) 1.15
    • Stable release target (x.y) 1.18
@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Apr 30, 2019

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network and removed needs-sig labels Apr 30, 2019
@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Apr 30, 2019

/assign prameshj

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Apr 30, 2019

/milestone v1.15
/stage beta

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Apr 30, 2019

@prameshj: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.15
/stage beta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kacole2 kacole2 added this to the v1.15 milestone Apr 30, 2019
@kacole2 kacole2 added the tracked/yes label Apr 30, 2019
@makoscafee

This comment has been minimized.

Copy link
Member

@makoscafee makoscafee commented May 10, 2019

Hey, @prameshj 👋 I'm the v1.15 docs Lead.
Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented May 10, 2019

Thanks, @makoscafee , I will open a PR and update the docs. Most of the code changes for this will be in the kubernetes/dns repo. I will update the docs and the image version in k/k. I'll open a placeholder PR in a day.

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented May 14, 2019

Pleaceholder PR : kubernetes/kubernetes#77887

@makoscafee

This comment has been minimized.

Copy link
Member

@makoscafee makoscafee commented May 15, 2019

Hi @prameshj above is not docs placeholder PR, right?

@kacole2

This comment has been minimized.

Copy link
Member

@kacole2 kacole2 commented May 28, 2019

Hi @prameshj . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented May 28, 2019

Thanks for the reminder, @kacole2

We need the following PRs merged:
kubernetes/kubernetes#78417
kubernetes/kubernetes#77887
Also, kubernetes/dns#302 and the new image to be used in the k/k yaml. I am planning to complete these by the code freeze deadline.

@makoscafee

This comment has been minimized.

Copy link
Member

@makoscafee makoscafee commented May 29, 2019

Hi @prameshj sorry! will this enhancement need user documentation in k/website apart from k/dns ? if yes can you open Placeholder PR before 30th which is the deadline for that. Thanks

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented May 30, 2019

Hi @prameshj sorry! will this enhancement need user documentation in k/website apart from k/dns ? if yes can you open Placeholder PR before 30th which is the deadline for that. Thanks

created kubernetes/website#14625

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented May 31, 2019

Forgot to mention, this PR needs to be in the 1.15 milestone as well.
kubernetes/kubernetes#78546

@kacole2

This comment has been minimized.

Copy link
Member

@kacole2 kacole2 commented Jul 8, 2019

Hi @prameshj , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@kacole2 kacole2 added tracked/no and removed tracked/yes labels Jul 9, 2019
@kacole2 kacole2 removed this from the v1.15 milestone Jul 9, 2019
@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Aug 14, 2019

Sorry for the delayed response, we are not graduating to stable in 1.16. Will try to target the next release.

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Oct 1, 2019

Hey there @prameshj -- 1.17 Enhancements shadow here 👋 . I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!!

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Oct 1, 2019

Hi @jeremyrickard , This has already graduated to beta in 1.15. We will target Stable in 1.18.

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Oct 1, 2019

@prameshj oops I removed the wrong stages when I was dropping the template in here! Thanks, I'll have this marked for 1.18!

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Oct 1, 2019

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Oct 1, 2019
@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Jan 22, 2020

Hey @prameshj how are you feeling about geting the KEP merged by Enhancement Freeze? We're about a week away!

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Jan 22, 2020

I am hopeful about merging the KEP before Jan 28th. I got an LGTM, will get it approved in the next few days, thanks for the reminder.

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Jan 27, 2020

Thank you @prameshj in being proactive for getting this through the requirements for Enhancements Freeze. Appreciate the efforts. :)

Please link the k/k or any other PR's here whenever there are are raised.

@iheanyi1

This comment has been minimized.

Copy link

@iheanyi1 iheanyi1 commented Feb 4, 2020

Hello @prameshj ,

I'm 1.18 docs shadow.

Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Warm regards,

chima

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Feb 4, 2020

There is an update to the website docs , this is the PR - kubernetes/website#18716
We are close to merging this, there is just one open comment.

@sftim

This comment has been minimized.

Copy link
Contributor

@sftim sftim commented Feb 4, 2020

BTW @prameshj the PR issue description says:

Graduate NodeLocal DNSCache to beta

(ie, beta not GA)

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Feb 5, 2020

BTW @prameshj the PR issue description says:

Graduate NodeLocal DNSCache to beta

(ie, beta not GA)

hmm.. where do you see this? I had renamed this issue title few months ago.

@sftim

This comment has been minimized.

Copy link
Contributor

@sftim sftim commented Feb 9, 2020

Screenshot

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Feb 11, 2020

Hey @prameshj,

Just a friendly reminder that code freeze for 1.18 is March 05, 2020.

As we track toward code freeze, please list out/link to any PRs you are working on toward graduating this enhancement!

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Feb 24, 2020

Hey @prameshj,

Just another friendly reminder that code freeze for 1.18 is March 05, 2020.
As a reminder, please link any k/k PRs here so we can better track this issue.

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Feb 24, 2020

The code-freeze is for k/k PRs correct?
I have the docs update PR that has lgtm, waiting for an approval - kubernetes/website#18716
The rest of the changes will be in kubernetes/dns and kubernetes/perf-tests repos. Do those need to be linked and completed by March 5 as well?

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Mar 3, 2020

@prameshj yeah, all of those should be completed by March 5th as well. If you can link them, that would be most helpful.

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Mar 6, 2020

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Mar 6, 2020

Hey @prameshj thanks for linking the k/k PR and the perf-test PR. The k/k PR is missing the 1.18 milestone, so it won't merge right now. Code Freeze was enabled earlier today, so all the PRs need to have the 1.18 milestone. You'll need to submit an exception request for this one at this point.

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Mar 6, 2020

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone Mar 6, 2020
@jeremyrickard jeremyrickard added tracked/no and removed tracked/yes labels Mar 6, 2020
@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Mar 6, 2020

@jeremyrickard Thanks for pointing this out - the PR kubernetes/kubernetes#88877 is ready to merge and I just added the milestone.
It is just changing the image version. I do not need an extension for making any more code changes, they are already made. Is the exception request in order to allow this PR to be merged?

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Mar 6, 2020

@jeremyrickard Just in case this is still needed, can you check if the request looks ok? I will send an email with this once i hear from you.
Enhancement name: NodeLocal DNSCache
Enhancement status (alpha/beta/stable): stable
SIG: Network
k/enhancements repo issue #: 1024
PR #’s: kubernetes/kubernetes#88877
Additional time needed (in days): 1
Reason this enhancement is critical for this milestone: This is a very important feature that improves DNS latency in kubernetes clusters.
Risks from adding code late: None
Risks from cutting enhancement: The feature went beta 3 releases ago in 1.15, missing this release for stable will make the graduation time much longer and create friction in usage of the feature.

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Mar 6, 2020

Also, the latest node-cache image can be used in any cluster and it has all the features we wanted for GA. The PR - kubernetes/kubernetes#88877 changes the version just for scripts using GCE, so it is not critical to make this change for graduating to GA.

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Mar 6, 2020

@prameshj yeah, please submit the exception request. What you showed as the example above looks good.

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Mar 6, 2020

Thanks @jeremyrickard , i just sent the email.

@prameshj

This comment has been minimized.

Copy link
Contributor Author

@prameshj prameshj commented Mar 6, 2020

@jeremyrickard Could you mark this enhancement as tracked for 1.18? Thanks!

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

@kikisdeliveryservice kikisdeliveryservice commented Mar 6, 2020

/milestone 1.18

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 6, 2020

@kikisdeliveryservice: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Mar 6, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
10 participants
You can’t perform that action at this time.