Skip to content

Commit

Permalink
DRA: move DriverName into 3063 KEP
Browse files Browse the repository at this point in the history
Structured parameters don't use the ResourceClass driver name for anything. All
that matters are the driver names in the individual requests and/or filters.
  • Loading branch information
pohly committed Apr 22, 2024
1 parent 3159f89 commit 4fe1b58
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 16 deletions.
21 changes: 18 additions & 3 deletions keps/sig-node/3063-dynamic-resource-allocation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -256,12 +256,18 @@ plane controller:
type ResourceClass struct {
...

// If (and only if) allocation of claims using this class is handled
// by the DRA driver, ControlPlaneController must be set to true.
// ControllerName defines the name of the dynamic resource driver that is
// used for allocation of a ResourceClaim that uses this class. If empty,
// structured parameters are used for allocating claims using this class.
//
// Resource drivers have a unique name in forward domain order
// (acme.example.com).
//
// This is an alpha field and requires enabling the DRAControlPlaneController
// feature gate.
ControlPlaneController bool
//
// +optional
ControllerName string
}
```

Expand Down Expand Up @@ -353,6 +359,15 @@ const (
```
type ResourceClaimStatus struct {
...
// ControllerName is a copy of the driver name from the ResourceClass at
// the time when allocation started. It is empty when the claim was
// allocated through structured parameters,
//
// This is an alpha field and requires enabling the DRAControlPlaneController
// feature gate.
//
// +optional
ControllerName string
// DeallocationRequested indicates that a ResourceClaim is to be
// deallocated.
Expand Down
13 changes: 0 additions & 13 deletions keps/sig-node/4381-dra-structured-parameters/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,6 @@ apiVersion: core.k8s.io/v1alpha2
kind: ResourceClass
metadata:
name: acme-gpu
driverName: gpu.example.com
parametersRef:
apiGroup: gpu.example.com
kind: GPUInit
Expand Down Expand Up @@ -1332,13 +1331,6 @@ type ResourceClass struct {
// +optional
metav1.ObjectMeta
// DriverName defines the name of the dynamic resource driver that is
// used for allocation of a ResourceClaim that uses this class.
//
// Resource drivers have a unique name in forward domain order
// (acme.example.com).
DriverName string
// ParametersRef references an arbitrary separate object that may hold
// parameters that will be used by the driver when allocating a
// resource that uses this class. A dynamic resource driver can
Expand Down Expand Up @@ -1478,11 +1470,6 @@ type ResourceClaimSpec struct {
// ResourceClaimStatus tracks whether the resource has been allocated and what
// the resulting attributes are.
type ResourceClaimStatus struct {
// DriverName is a copy of the driver name from the ResourceClass at
// the time when allocation started.
// +optional
DriverName string
// Allocation is set by the resource driver once a resource or set of
// resources has been allocated successfully. If this is not specified, the
// resources have not been allocated yet.
Expand Down

0 comments on commit 4fe1b58

Please sign in to comment.