Skip to content

Commit

Permalink
Merge pull request #1527 from vpickard/topology-manager-test-plan
Browse files Browse the repository at this point in the history
Update Topology Manager KEP with a Test Plan section
  • Loading branch information
k8s-ci-robot committed Feb 3, 2020
2 parents de4c386 + 63ae0e9 commit e045d37
Showing 1 changed file with 40 additions and 0 deletions.
40 changes: 40 additions & 0 deletions keps/sig-node/0035-20190130-topology-manager.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ _Reviewers:_
- [Alpha (v1.17) [COMPLETED]](#alpha-v117-completed)
- [Beta (target v1.18)](#beta-target-v118)
- [GA (stable)](#ga-stable)
- [Test Plan](#test-plan)
- [Single NUMA Systems Tests](#single-numa-systems-tests)
- [Multi-NUMA Systems Tests](#multi-numa-systems-tests)
- [Future Tests](#future-tests)
- [Challenges](#challenges)
- [Limitations](#limitations)
- [Alternatives](#alternatives)
Expand Down Expand Up @@ -439,6 +443,42 @@ _Figure: Topology Manager fetches affinity from hint providers._
* User feedback.
* *TBD*

# Test Plan

There is a presubmit job for Topology Manager, that will be run on
all PRs. This job is here:
https://testgrid.k8s.io/wg-resource-management#pr-kubelet-serial-gce-e2e-topology-manager

There is a CI job for Topology Manager that will run periodically. This
job is here:
https://testgrid.k8s.io/wg-resource-management#pr-kubelet-serial-gce-e2e-topology-manager

The Topology Manager E2E test will enable the Topology Manager
feature gate and set the CPU Manager policy to 'static'.

At the beginning of the test, the code will determine if the system
under test has support for single or multi-NUMA nodes.

## Single NUMA Systems Tests
For each of the four topology manager policies, the tests will
run a subset of the current CPU Manager tests. This includes spinning
up non-guaranteed pods, guaranteed pods, and multiple guaranteed and
non-guaranteed pods. As with the CPU Manager tests, CPU assignment is
validated. Tests related to multi-NUMA systems will be skipped, and
a log will be generated indicating such.

## Multi-NUMA Systems Tests
For each of the four topology manager policies, the tests will spin up
guaranteed pods and non-guaranteed pods, requesting CPU and device
resources. When the policy is set to single-numa-node for guaranteed pods,
the test will verify that guaranteed pods resources (CPU and devices)
are aligned on the same NUMA node. Initially, the test will request
SR-IOV devices, utilizing the SR-IOV device plugin.

## Future Tests
It would be good to add additional devices, such as GPU, in the multi-NUMA
systems test.

# Challenges

* Testing the Topology Manager in a continuous integration environment
Expand Down

0 comments on commit e045d37

Please sign in to comment.