Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Topology Manager KEP with a Test Plan section #1527

Merged
merged 2 commits into from Feb 3, 2020
Merged

Update Topology Manager KEP with a Test Plan section #1527

merged 2 commits into from Feb 3, 2020

Conversation

vpickard
Copy link
Contributor

Add a Test Section to cover test plans for single and
multi-NUMA systems.

Signed-off-by: vpickard vpickard@redhat.com

@vpickard
Update Topology Manager KEP with a Test Plan section
b71e34a 
Add a Test Section to cover test plans for single and
multi-NUMA systems.

Signed-off-by: vpickard <vpickard@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @vpickard!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @vpickard. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2020
@vpickard
Copy link
Contributor Author

/cc @klueska @nolancon

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jan 29, 2020
@nolancon
Copy link

nolancon commented Jan 30, 2020 •
edited

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2020
@nolancon
Copy link

/assign @derekwaynecarr

@nolancon
Copy link

nolancon commented Jan 30, 2020 •
edited

@vpickard Looks like it's failing on the Table of Contents - Probably needs to be updated with new Test Plan section also.
run ./hack/update-toc.sh

nolancon
nolancon reviewed Jan 30, 2020
View reviewed changes
Copy link

@nolancon nolancon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits. TOC should be updated after - see above comment.

keps/sig-node/0035-20190130-topology-manager.md Outdated Show resolved Hide resolved
keps/sig-node/0035-20190130-topology-manager.md Outdated Show resolved Hide resolved
keps/sig-node/0035-20190130-topology-manager.md Outdated Show resolved Hide resolved
keps/sig-node/0035-20190130-topology-manager.md Outdated Show resolved Hide resolved
@nolancon
Copy link

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2020
@vpickard
Copy link
Contributor Author

@vpickard Looks like it's failing on the Table of Contents - Probably needs to be updated with new Test Plan section also.
run ./hack/update-toc.sh

Thanks for the Tip!

@vpickard
Fix Table of Contents
63ae0e9 
And address some comments from initial commit.

Signed-off-by: vpickard <vpickard@redhat.com>
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, vpickard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit e045d37 into kubernetes:master Feb 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 3, 2020
@klueska klueska mentioned this pull request Feb 4, 2020
Closed
11 tasks
@vpickard vpickard mentioned this pull request May 21, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska klueska left review comments

@nolancon nolancon nolancon left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@derekwaynecarr derekwaynecarr

@nolancon nolancon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vpickard @k8s-ci-robot @nolancon @derekwaynecarr @klueska