Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Enhance daemonset on rollingupdate #1352

Closed
zhangxiaoyu-zidif opened this issue Nov 4, 2019 · 20 comments
Closed

[WIP]Enhance daemonset on rollingupdate #1352

zhangxiaoyu-zidif opened this issue Nov 4, 2019 · 20 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@zhangxiaoyu-zidif
Copy link

zhangxiaoyu-zidif commented Nov 4, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note):
    Now we need to enhance DaemonSet update strategy in gray update.

  • Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR)
    [WIP] Enhance daemonset on rollingupdate. #1140

  • Primary contact (assignee):
    @zhangxiaoyu-zidif

  • Responsible SIGs:
    SIG-APP

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y)
      1.18

    • Beta release target (x.y)
      1.19

    • Stable release target (x.y)
      1.20

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 4, 2019
@k8s-ci-robot
Copy link
Contributor

@zhangxiaoyu-zidif: The label(s) sig/app cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

Enhancement Description

  • One-line enhancement description (can be used as a release note):
    Now we need to enhance DaemonSet update strategy in gray update.

  • Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR)
    [WIP] Enhance daemonset on rollingupdate. #1140

  • Primary contact (assignee):
    @zhangxiaoyu-zidif

  • Responsible SIGs:
    /sig app

  • Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y)
    1.18

  • Beta release target (x.y)
    1.19

  • Stable release target (x.y)
    1.20

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrbobbytables mrbobbytables added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Dec 1, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 1, 2019
@mrbobbytables mrbobbytables added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Dec 1, 2019
@palnabarun
Copy link
Member

palnabarun commented Jan 13, 2020

Hey there @zhangxiaoyu-zidif -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.18 or having a major change in its current level?

The current release schedule is:

  • Monday, January 6th - Release Cycle Begins
  • Tuesday, January 28th EOD PST - Enhancements Freeze
  • Thursday, March 5th, EOD PST - Code Freeze
  • Monday, March 16th - Docs must be completed and reviewed
  • Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release,

  1. The KEP PR must be merged
  2. The KEP must be in an implementable state
  3. The KEP must have test plans and graduation criteria.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements

Thanks! :)

@palnabarun
Copy link
Member

@zhangxiaoyu-zidif Just a friendly reminder, we are just 7 days away from the Enhancement Freeze (Tuesday, January 28th).

@palnabarun
Copy link
Member

@zhangxiaoyu-zidif Just a friendly reminder, we are just 2 days away from the Enhancement Freeze (3 PM Pacific Time, Tuesday, January 28th).

@palnabarun
Copy link
Member

Unfortunately, the deadline for the 1.18 Enhancement freeze has passed. For now, this is being removed from the milestone. If there is a need to get this in, please file an enhancement exception.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2020
@palnabarun
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2020
@harshanarayana
Copy link

Hey there @zhangxiaoyu-zidif -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@harshanarayana
Copy link

Hey @zhangxiaoyu-zidif, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

1 similar comment
@harshanarayana
Copy link

Hey @zhangxiaoyu-zidif, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

@harshanarayana
Copy link

Hey @zhangxiaoyu-zidif, any plans for the Enhancements to be included in v1.19? Please let me know so that I can update the tracking sheet to show the inclusion state.

Enhancements freeze is on May 19

Note that recently the KEP format has changed. Additionally, #1620 merged recently, adding production readiness review questions to the KEP template.
Please take this opportunity to reformat your KEP and also answer the questions added to the template in that PR.

Thanks,
🖖

@harshanarayana
Copy link

Hey @zhangxiaoyu-zidif, Unfortunately the deadline for the 1.19 Enhancement freeze has passed and the KEP for it is still in flight and missing Test Plan and Graduation Criteria. For now this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@palnabarun
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020
@kikisdeliveryservice
Copy link
Member

Hi @zhangxiaoyu-zidif

Enhancements Lead here. Any plans for this in 1.20? I notice that the KEP has been closed, should this issue remain open?

Thanks!
Kirsten

@kikisdeliveryservice
Copy link
Member

@zhangxiaoyu-zidif Following up, do you have any plans for 1.20? I note that the KEP has been closed and no new KEP has been attached. Enhancements Freeze is October 6th, if you intend to graduate please let me know.

Best,
Kirsten

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 26, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

7 participants