Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PV Health Monitor #1432

Open
xing-yang opened this issue Jan 5, 2020 · 109 comments
Open

PV Health Monitor #1432

xing-yang opened this issue Jan 5, 2020 · 109 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@xing-yang
Copy link
Contributor

xing-yang commented Jan 5, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note):
Provide a PV health monitor to watch the health status of volumes and mark it if a PV becomes unhealthy.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 5, 2020
@xing-yang
Copy link
Contributor Author

xing-yang commented Jan 5, 2020

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 5, 2020
@xing-yang
Copy link
Contributor Author

xing-yang commented Jan 5, 2020

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 5, 2020
@xing-yang
Copy link
Contributor Author

xing-yang commented Jan 5, 2020

/assign @xing-yang

@xing-yang
Copy link
Contributor Author

xing-yang commented Jan 5, 2020

/assign @NickrenREN

@xing-yang
Copy link
Contributor Author

xing-yang commented Jan 5, 2020

/milestone v1.18

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 5, 2020

@xing-yang: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Copy link
Contributor Author

xing-yang commented Jan 5, 2020

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 5, 2020
@xing-yang
Copy link
Contributor Author

xing-yang commented Jan 9, 2020

Hi @jeremyrickard, can you help add this feature to the milestone? We are targeting Alpha in 1.18. Thanks!

@jeremyrickard jeremyrickard added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 15, 2020
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 22, 2020

Hey there @xing-yang,

Checking in to see if you're still on track for 1.18? It looks like the KEP still hasn't been merged. As a reminder, that will need to occur before the Enhancement Freeze (end of day, Pacific Time, on January 28th).

Thanks!!

@xing-yang
Copy link
Contributor Author

xing-yang commented Jan 22, 2020

@jeremyrickard Yes, we are still trying to get it merged by 1/28. Thanks!

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 29, 2020

@xing-yang congrats on getting the KEP merged! Updated you to tracked in the sheet!

@xing-yang
Copy link
Contributor Author

xing-yang commented Jan 29, 2020

Thanks @jeremyrickard !

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jan 29, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 29, 2020
@VineethReddy02
Copy link

VineethReddy02 commented Feb 5, 2020

Hello, @xing-yang, I'm 1.18 docs lead.
Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@xing-yang
Copy link
Contributor Author

xing-yang commented Feb 5, 2020

Hi @VineethReddy02, I'll submit a doc PR placeholder soon. Thanks!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Feb 10, 2020

Hi @xing-yang !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement when available?

Thanks!
The 1.18 Enhancements Team

@NickrenREN
Copy link
Member

NickrenREN commented Feb 10, 2020

Hi, @kikisdeliveryservice ,
We have started coding for this, but this is mostly out of tree(out of k8s core repo). So we probably do not need to follow the release timeline strictly.
But of course, if we send out the PRs, we will link them here.
Thanks

@xing-yang
Copy link
Contributor Author

xing-yang commented Feb 20, 2020

CSI Spec PR is submitted here: container-storage-interface/spec#415

@xing-yang
Copy link
Contributor Author

xing-yang commented Feb 20, 2020

Hi @VineethReddy02, I think the doc for this feature will be in kubernetes-csi/docs repo, not in kubernetes website repo. Can you please remove the doc requirement for this feature from the tracking sheet? Thanks!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Mar 2, 2020

/milestone clear

@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@xing-yang
Copy link
Contributor Author

xing-yang commented May 23, 2022

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 23, 2022
@xing-yang xing-yang added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels May 23, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 3, 2022
@Atharva-Shinde
Copy link

Atharva-Shinde commented Jun 6, 2022

Hello @xing-yang 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage beta for 1.25 release

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has an updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

Open PR #3321

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Atharva-Shinde
Copy link

Atharva-Shinde commented Jun 13, 2022

Hello @xing-yang 👋, just a quick check-in again.

The enhancements freeze for 1.25 starts on this Thursday, June 16, 2022 at 18:00 PM PT.

Currently the status of the Pull Request #3321 is-

Before the enhancements freeze commences, please try to get the pull request #3321 merged incorporating the changes suggested above :)

For note, the current status of the enhancement is still at-risk.

@Atharva-Shinde
Copy link

Atharva-Shinde commented Jun 14, 2022

Hey @xing-yang 👋
A good news! Enhancements Freeze is now extended to next week on Thursday June 23, 2022 🚀
So we now have one more week to submit the KEP :)

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 21, 2022

Hello @xing-yang, looks like the open PR #3321 is still waiting for a SIG approval/lgtm

Please plan to get the following pending items done & get the PR merged before enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT.

  • The Test Plan Section is still missing adding the following acknowledgement checkbox.
[ ] I/we understand the owners of the involved components may require updates to
existing tests to make this code solid enough prior to committing the changes necessary
to implement this enhancement.

For note, the current status of the enhancement is atat-risk. Thank you!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 24, 2022

Hello, 1.25 Enhancements Lead here 👋. With Enhancements Freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for enhancements freeze is:

  • KEP file using the latest template has been merged into the k/enhancements repo, with up to date latest milestone and stage
  • KEP status is marked as implementable
  • KEP has an updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Jun 24, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jun 24, 2022
@xing-yang xing-yang added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 12, 2022
@xing-yang
Copy link
Contributor Author

xing-yang commented Sep 12, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 12, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 18, 2022

Hello @xing-yang @NickrenREN 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@rhockenbury rhockenbury added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 18, 2022
@rhockenbury
Copy link

rhockenbury commented Oct 1, 2022

Quick reminder - Enhancement freeze is about a week away. If you are still looking to get this enhancement into v1.26, please plan to make the updates to the KEP yaml and README.

@xing-yang
Copy link
Contributor Author

xing-yang commented Oct 4, 2022

Quick reminder - Enhancement freeze is about a week away. If you are still looking to get this enhancement into v1.26, please plan to make the updates to the KEP yaml and README.

@rhockenbury Thanks for the reminder! The KEP merge is blocked because e2e tests are not complete yet.

@xing-yang
Copy link
Contributor Author

xing-yang commented Oct 5, 2022

@rhockenbury We won't get the e2e tests ready by the KEP merge deadline. So we are moving this to 1.27.

@xing-yang xing-yang removed this from the v1.26 milestone Oct 5, 2022
@xing-yang xing-yang removed the lead-opted-in Denotes that an issue has been opted in to a release label Oct 5, 2022
@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

No problem. Thanks for the update.

/milestone clear
/label tracked/no
/remove-label tracked/yes

@k8s-ci-robot k8s-ci-robot added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Graduating
Development

No branches or pull requests