Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic data populators #1495

Open
bswartz opened this issue Jan 22, 2020 · 122 comments
Open

Generic data populators #1495

bswartz opened this issue Jan 22, 2020 · 122 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@bswartz
Copy link
Contributor

bswartz commented Jan 22, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note): Allow generic data populators by permitting any object to be the data sources for a PVC
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1495-volume-populators
  • Primary contact (assignee): @bswartz
  • Responsible SIGs: sig-storage, sig-api-machinery
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.18)
    • Beta release target (1.23)
    • Stable release target (1.33)

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

Tracking PRs:

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 22, 2020
@bswartz
Copy link
Contributor Author

bswartz commented Jan 22, 2020

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 22, 2020
@jeremyrickard
Copy link
Contributor

Hey @bswartz, I see you've targeted this going Alpha in 1.18. This is a friendly notice that to be included in 1.18, you'll need to have the KEP merged as implementable and it will need to have graduation criteria and a test plan. Your KEP PR looks like it's missing both of those and is marked as provisional. If you could please confirm that you plan on making this go alpha in 1.18, we can conditionally track it but you will need to have the KEP updated before Enhancement Freeze, on January 28th (end of day Pacific time).

@jeremyrickard jeremyrickard added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jan 23, 2020
@bswartz
Copy link
Contributor Author

bswartz commented Jan 24, 2020

@jeremyrickard Thanks I do hope for this KEP to be targeted at 1.18, but that depends mostly on the reviewers agreeing with the approach in general. I will update the document itself to include graduation criteria and a test plan.

@bswartz
Copy link
Contributor Author

bswartz commented Jan 27, 2020

@jeremyrickard I filled in the missing sections. Still working with approvers on getting approval. Let me know if there's anything else essential you think I should add.

@bswartz
Copy link
Contributor Author

bswartz commented Jan 29, 2020

@jeremyrickard Got the KEP approved, and you please track this now?

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 29, 2020

/milestone v1.18

Hey @bswartz the KEP needs to be updated to implementable. Can you do a quick PR to update the status to implementable? We can file an exception tomorrow to make sure it gets in, but the KEP will need that status.

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 29, 2020
@jeremyrickard jeremyrickard added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 29, 2020
@VineethReddy02
Copy link

VineethReddy02 commented Feb 5, 2020

Hello, @bswartz, I'm 1.18 docs lead.
Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@bswartz
Copy link
Contributor Author

bswartz commented Feb 7, 2020

@VineethReddy02 Yes there will be at least a small docs update with this change.

@kikisdeliveryservice
Copy link
Member

Hi @bswartz !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement?

Thanks!
The 1.18 Enhancements Team

@VineethReddy02
Copy link

Hello @bswartz
We are close to the docs placeholder PR deadline against the dev-1.18 branch. Having a placeholder PR in place will definitely help us in tracking enhancements much better.

Thanks! :)

@jeremyrickard
Copy link
Contributor

Hi @bswartz !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement?

Thanks!
The 1.18 Enhancements Team

@bswartz
Copy link
Contributor Author

bswartz commented Feb 25, 2020

kubernetes/website#19315

@bswartz
Copy link
Contributor Author

bswartz commented Feb 25, 2020

Will add k/k PR next

@bswartz
Copy link
Contributor Author

bswartz commented Feb 27, 2020

@kikisdeliveryservice
Copy link
Member

@bswartz As a reminder code freeze is March 5th. Is this still on track for 1.18? Thank you!

@bswartz
Copy link
Contributor Author

bswartz commented Mar 2, 2020

@kikisdeliveryservice Yes, completely on track! I just need some reviews on my PR and for it to merge. I'm working on docs in parallel. Is there anything missing that you're aware of?

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Mar 2, 2020

@bswartz Just wanted to check in to make sure your work got in by the deadline :)

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Mar 4, 2020

As a reminder code freeze is tomorrow for 1.18 and all PRs should be merged by then.

-Enhancements Team

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 17, 2020
@palnabarun
Copy link
Member

/milestone clear

(removing from 1.18 since it didn't go into that release)

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone Apr 28, 2020
@palnabarun
Copy link
Member

Hi @bswartz -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?


The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@k8s-ci-robot k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 6, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xing-yang
Copy link
Contributor

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

@xing-yang: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xing-yang
Copy link
Contributor

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 28, 2024
@xing-yang xing-yang added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 14, 2025
@xing-yang xing-yang added this to the v1.33 milestone Jan 14, 2025
@xing-yang xing-yang added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jan 14, 2025
@xing-yang
Copy link
Contributor

/assign @sunnylovestiramisu

@dipesh-rawat
Copy link
Member

Hello @xing-yang @sunnylovestiramisu 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage stable for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • Please ensure the KEP readme using the latest template and merge it in the k/enhancements repo. Currently, I’ve noticed the following discrepancies compared to the latest template:

    • Under the "Monitoring Requirements" section, the question How can someone using this feature know that it is working for their instance? is missing.

    • Under the Scalability section, the question Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)? is missing.

  • Also, please make sure to update the issue description with the correct stages and PRs. This will assist the release team in tracking progress more effectively.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@sunnylovestiramisu
Copy link
Contributor

@dipesh-rawat Updated

@dipesh-rawat
Copy link
Member

Hello @sunnylovestiramisu 👋,

Now that PR #5101 has been merged, all the KEP requirements are in place and merged into k/enhancements. This enhancement is all good for the upcoming enhancements freeze. 🚀

Before the enhancement freeze, it would be appreciated if following nits could be addressed:

  • Update the issue description to correctly specify the Stable release target as 1.33. Additionally, make sure to list all PRs that will be part of the release as part of the work for this enhancement in the description, for tracking purposes.

Aside from the minor nit mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@dipesh-rawat dipesh-rawat moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Jan 31, 2025
@dipesh-rawat dipesh-rawat added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 2, 2025
@hacktivist123
Copy link

Hello @sunnylovestiramisu 👋, v1.33 Docs Shadow here.
Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@sunnylovestiramisu
Copy link
Contributor

@hacktivist123 The website and blog posts are listed in the description.

ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Feb 26, 2025
@dipesh-rawat
Copy link
Member

Hey again @sunnylovestiramisu 👋, 1.33 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

With all the implementation(code related) PRs merged as per the issue description:

Additionally, please let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.

This enhancement is now marked as tracked for code freeze for the 1.33 Code Freeze!

@dipesh-rawat dipesh-rawat moved this from Tracked for enhancements freeze to Tracked for code freeze in 1.33 Enhancements Tracking Feb 28, 2025
@Udi-Hofesh
Copy link
Member

Hey @bswartz 👋 -- this is Udi (@Udi-Hofesh) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features that fall into (but are not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timelines to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@Udi-Hofesh
Copy link
Member

Hi @bswartz 👋, 1.33 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 5th March, 2025. This is in just several hours! To opt in, please let us know and open a Feature Blog placeholder PR against k/website by the deadline. If you have any questions, please feel free to reach out to us!

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Removed from Milestone
Status: Tracked for code freeze
Development

No branches or pull requests