Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic data populators #1495

Open
bswartz opened this issue Jan 22, 2020 · 96 comments
Open

Generic data populators #1495

bswartz opened this issue Jan 22, 2020 · 96 comments
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@bswartz
Copy link
Contributor

bswartz commented Jan 22, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note): Allow generic data populators by permitting any object to be the data sources for a PVC
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1495-volume-populators
  • Primary contact (assignee): @bswartz
  • Responsible SIGs: sig-storage, sig-api-machinery
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.18)
    • Beta release target (1.23)
    • Stable release target (x.y)

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 22, 2020
@bswartz
Copy link
Contributor Author

bswartz commented Jan 22, 2020

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 22, 2020
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 23, 2020

Hey @bswartz, I see you've targeted this going Alpha in 1.18. This is a friendly notice that to be included in 1.18, you'll need to have the KEP merged as implementable and it will need to have graduation criteria and a test plan. Your KEP PR looks like it's missing both of those and is marked as provisional. If you could please confirm that you plan on making this go alpha in 1.18, we can conditionally track it but you will need to have the KEP updated before Enhancement Freeze, on January 28th (end of day Pacific time).

@jeremyrickard jeremyrickard added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jan 23, 2020
@bswartz
Copy link
Contributor Author

bswartz commented Jan 24, 2020

@jeremyrickard Thanks I do hope for this KEP to be targeted at 1.18, but that depends mostly on the reviewers agreeing with the approach in general. I will update the document itself to include graduation criteria and a test plan.

@bswartz
Copy link
Contributor Author

bswartz commented Jan 27, 2020

@jeremyrickard I filled in the missing sections. Still working with approvers on getting approval. Let me know if there's anything else essential you think I should add.

@bswartz
Copy link
Contributor Author

bswartz commented Jan 29, 2020

@jeremyrickard Got the KEP approved, and you please track this now?

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 29, 2020

/milestone v1.18

Hey @bswartz the KEP needs to be updated to implementable. Can you do a quick PR to update the status to implementable? We can file an exception tomorrow to make sure it gets in, but the KEP will need that status.

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 29, 2020
@jeremyrickard jeremyrickard added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 29, 2020
@VineethReddy02
Copy link

VineethReddy02 commented Feb 5, 2020

Hello, @bswartz, I'm 1.18 docs lead.
Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@bswartz
Copy link
Contributor Author

bswartz commented Feb 7, 2020

@VineethReddy02 Yes there will be at least a small docs update with this change.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Feb 10, 2020

Hi @bswartz !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement?

Thanks!
The 1.18 Enhancements Team

@VineethReddy02
Copy link

VineethReddy02 commented Feb 21, 2020

Hello @bswartz
We are close to the docs placeholder PR deadline against the dev-1.18 branch. Having a placeholder PR in place will definitely help us in tracking enhancements much better.

Thanks! :)

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Feb 24, 2020

Hi @bswartz !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement?

Thanks!
The 1.18 Enhancements Team

@bswartz
Copy link
Contributor Author

bswartz commented Feb 25, 2020

kubernetes/website#19315

@bswartz
Copy link
Contributor Author

bswartz commented Feb 25, 2020

Will add k/k PR next

@bswartz
Copy link
Contributor Author

bswartz commented Feb 27, 2020

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Mar 2, 2020

@bswartz As a reminder code freeze is March 5th. Is this still on track for 1.18? Thank you!

@bswartz
Copy link
Contributor Author

bswartz commented Mar 2, 2020

@kikisdeliveryservice Yes, completely on track! I just need some reviews on my PR and for it to merge. I'm working on docs in parallel. Is there anything missing that you're aware of?

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Mar 2, 2020

@bswartz Just wanted to check in to make sure your work got in by the deadline :)

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Mar 4, 2020

As a reminder code freeze is tomorrow for 1.18 and all PRs should be merged by then.

-Enhancements Team

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 17, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 28, 2020

/milestone clear

(removing from 1.18 since it didn't go into that release)

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone Apr 28, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 28, 2020

Hi @bswartz -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?


The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 12, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 17, 2022

Hello @bswartz 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting beta for 1.24, is this correct?

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review for stage beta that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

The status of this enhancement is track as at risk. Please update this issue description with appropriate stages as well. Thank you!

@bswartz
Copy link
Contributor Author

bswartz commented Jan 26, 2022

Sorry for slow response. Yes, this is targeting beta for 1.24. I know I need to update the version for the KEP.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 27, 2022

Thanks so much for the update, @bswartz.

I'm just checking in again, as we approach the 1.24 enhancements freeze in a week now, on Thursday, February 3rd, 2022 at 18:00 PM PT.

I know I need to update the version for the KEP.

With the above change, this enhancement would be ready for the upcoming enhancements freeze. Currently, the status is still at risk.

Could you also please link the PR for the above changes in the issue. I would keep an eye & update the tracking sheet as it gets merged. Thank you so much once again! 🙂

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Feb 2, 2022

With the KEP PR #3200 merged now, this enhancement is ready for the 1.24 enhancements freeze tomorrow. 🚀

For note, the enhancement status is now marked tracked in the 1.24 tracking sheet. Thank you!

@didicodes
Copy link

didicodes commented Feb 13, 2022

Hi @bswartz, 1.24 Docs shadow here. 👋

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙌

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 18, 2022

Hello @bswartz 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as at risk.

Kindly please let me know if I'm missing any open PRs other than the ones I linked above. Thank you so much!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 30, 2022

@bswartz, with k/k code implementation PR kubernetes/kubernetes#108736 merged now, the status of the enhancement is tracked 🚀. Thank you!

@bswartz
Copy link
Contributor Author

bswartz commented Mar 30, 2022

Thanks!

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 8, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Sep 7, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 7, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Oct 7, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 7, 2022

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Member

jsafrane commented Oct 11, 2022

/reopen
It's Beta and it has not been removed from the code.

@k8s-ci-robot k8s-ci-robot reopened this Oct 11, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 11, 2022

@jsafrane: Reopened this issue.

In response to this:

/reopen
It's Beta and it has not been removed from the code.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Member

jsafrane commented Oct 11, 2022

I found one issue that I'd like to be fixed before GA: kubernetes-csi/lib-volume-populator#41

@msau42
Copy link
Member

msau42 commented Oct 26, 2022

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests